mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: linux-kernel@vger.kernel.org
Cc: Peter Rosin <peda@axentia.se>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH] drm: atmel-hlcdc: use a default gamma ramp if none is specified
Date: Mon,  3 Jul 2017 11:42:10 +0200	[thread overview]
Message-ID: <1499074930-10187-1-git-send-email-peda@axentia.se> (raw)

At init and if the gamma_lut property is ever removed, the clut
registers must be programmed with a default gamma ramp instead of
being left in some unknown state.

Fixes: 364a7bf574eb ("drm: atmel-hlcdc: add support for 8-bit color lookup table mode")
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
index b5bd9b0..0ccd93c 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
@@ -429,6 +429,14 @@ static void atmel_hlcdc_plane_update_format(struct atmel_hlcdc_plane *plane,
 				    ATMEL_HLCDC_LAYER_FORMAT_CFG, cfg);
 }
 
+static void atmel_hlcdc_default_gamma_ramp(struct atmel_hlcdc_layer *layer)
+{
+	int idx;
+
+	for (idx = 0; idx < ATMEL_HLCDC_CLUT_SIZE; idx++)
+		atmel_hlcdc_layer_write_clut(layer, idx, idx * 0x10101);
+}
+
 static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane)
 {
 	struct drm_crtc *crtc = plane->base.crtc;
@@ -438,9 +446,14 @@ static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane)
 	if (!crtc || !crtc->state)
 		return;
 
-	if (!crtc->state->color_mgmt_changed || !crtc->state->gamma_lut)
+	if (!crtc->state->color_mgmt_changed)
 		return;
 
+	if (!crtc->state->gamma_lut) {
+		atmel_hlcdc_default_gamma_ramp(&plane->layer);
+		return;
+	}
+
 	lut = (struct drm_color_lut *)crtc->state->gamma_lut->data;
 
 	for (idx = 0; idx < ATMEL_HLCDC_CLUT_SIZE; idx++, lut++) {
@@ -918,6 +931,8 @@ static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane,
 					    0x40040890);
 	}
 
+	atmel_hlcdc_default_gamma_ramp(&plane->layer);
+
 	return 0;
 }
 
-- 
2.1.4

             reply	other threads:[~2017-07-03  9:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03  9:42 Peter Rosin [this message]
2017-07-03 11:31 ` Boris Brezillon
2017-07-03 11:53   ` Peter Rosin
2017-07-03 12:02     ` Boris Brezillon
2017-07-03 20:59       ` Peter Rosin
2017-07-03 21:15         ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499074930-10187-1-git-send-email-peda@axentia.se \
    --to=peda@axentia.se \
    --cc=airlied@linux.ie \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®