From: Patrick Bellasi <patrick.bellasi@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Juri Lelli <juri.lelli@arm.com>,
Joel Fernandes <joelaf@google.com>,
Andres Oportus <andresoportus@google.com>,
Todd Kjos <tkjos@android.com>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>
Subject: [PATCH v2 6/6] cpufreq: schedutil: relax rate-limiting while running RT/DL tasks
Date: Tue, 4 Jul 2017 18:34:11 +0100 [thread overview]
Message-ID: <1499189651-18797-7-git-send-email-patrick.bellasi@arm.com> (raw)
In-Reply-To: <1499189651-18797-1-git-send-email-patrick.bellasi@arm.com>
The policy in use for RT/DL tasks sets the maximum frequency when a task
in these classes calls for a cpufreq_update_this_cpu(). However, the
current implementation is still enforcing a frequency switch rate
limiting when these tasks are running.
This is potentially working against the goal to switch to the maximum OPP
when RT tasks are running. In certain unfortunate cases it can also happen
that a RT task almost completes its activation at a lower OPP.
This patch overrides on purpose the rate limiting configuration
to better serve RT/DL tasks. As long as a frequency scaling operation
is not in progress, a frequency switch is always authorized when
running in "rt_mode", i.e. the current task in a CPU belongs to the
RT/DL class.
Signed-off-by: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org
---
kernel/sched/cpufreq_schedutil.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index df433f1..7b1dc7e 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -72,7 +72,8 @@ static DEFINE_PER_CPU(struct sugov_cpu, sugov_cpu);
/************************ Governor internals ***********************/
-static bool sugov_should_update_freq(struct sugov_policy *sg_policy, u64 time)
+static bool sugov_should_update_freq(struct sugov_policy *sg_policy,
+ u64 time, bool rt_mode)
{
s64 delta_ns;
@@ -89,6 +90,10 @@ static bool sugov_should_update_freq(struct sugov_policy *sg_policy, u64 time)
return true;
}
+ /* Always update if a RT/DL task is running */
+ if (rt_mode)
+ return true;
+
delta_ns = time - sg_policy->last_freq_update_time;
return delta_ns >= sg_policy->freq_update_delay_ns;
}
@@ -226,11 +231,6 @@ static void sugov_update_single(struct update_util_data *hook, u64 time,
sugov_set_iowait_boost(sg_cpu, time, flags);
sg_cpu->last_update = time;
- if (!sugov_should_update_freq(sg_policy, time))
- return;
-
- busy = sugov_cpu_is_busy(sg_cpu);
-
/*
* While RT/DL tasks are running we do not want FAIR tasks to
* overvrite this CPU's flags, still we can update utilization and
@@ -239,6 +239,11 @@ static void sugov_update_single(struct update_util_data *hook, u64 time,
rt_mode = task_has_dl_policy(current) ||
task_has_rt_policy(current) ||
(flags & SCHED_CPUFREQ_RT_DL);
+ if (!sugov_should_update_freq(sg_policy, time, rt_mode))
+ return;
+
+ busy = sugov_cpu_is_busy(sg_cpu);
+
if (rt_mode) {
next_f = policy->cpuinfo.max_freq;
} else {
@@ -336,7 +341,7 @@ static void sugov_update_shared(struct update_util_data *hook, u64 time,
sugov_set_iowait_boost(sg_cpu, time, flags);
sg_cpu->last_update = time;
- if (sugov_should_update_freq(sg_policy, time)) {
+ if (sugov_should_update_freq(sg_policy, time, rt_mode)) {
next_f = rt_mode
? sg_policy->policy->cpuinfo.max_freq
: sugov_next_freq_shared(sg_cpu, time);
--
2.7.4
next prev parent reply other threads:[~2017-07-04 17:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 17:34 [PATCH v2 0/6] cpufreq: schedutil: fixes for flags updates Patrick Bellasi
2017-07-04 17:34 ` [PATCH v2 1/6] cpufreq: schedutil: ignore sugov kthreads Patrick Bellasi
2017-07-05 5:00 ` Viresh Kumar
2017-07-05 11:38 ` Patrick Bellasi
2017-07-06 4:50 ` Viresh Kumar
2017-07-06 22:18 ` Rafael J. Wysocki
2017-07-11 19:08 ` Saravana Kannan
2017-07-04 17:34 ` [PATCH v2 2/6] cpufreq: schedutil: reset sg_cpus's flags at IDLE enter Patrick Bellasi
2017-07-05 4:50 ` Viresh Kumar
2017-07-05 13:04 ` Patrick Bellasi
2017-07-06 5:46 ` Viresh Kumar
2017-07-07 4:43 ` Joel Fernandes
2017-07-07 10:17 ` Juri Lelli
2017-07-11 19:16 ` Saravana Kannan
2017-07-04 17:34 ` [PATCH v2 3/6] cpufreq: schedutil: ensure max frequency while running RT/DL tasks Patrick Bellasi
2017-07-05 6:01 ` Viresh Kumar
2017-07-05 13:41 ` Patrick Bellasi
2017-07-06 5:56 ` Viresh Kumar
2017-07-07 5:26 ` Joel Fernandes
2017-07-04 17:34 ` [PATCH v2 4/6] cpufreq: schedutil: update CFS util only if used Patrick Bellasi
2017-07-07 5:58 ` Joel Fernandes
2017-07-07 6:44 ` Vikram Mulukutla
2017-07-08 6:14 ` Joel Fernandes
2017-07-10 17:49 ` Vikram Mulukutla
2017-07-11 5:19 ` Joel Fernandes
2017-07-04 17:34 ` [PATCH v2 5/6] sched/rt: fast switch to maximum frequency when RT tasks are scheduled Patrick Bellasi
2017-07-04 17:34 ` Patrick Bellasi [this message]
2017-07-06 22:26 ` [PATCH v2 0/6] cpufreq: schedutil: fixes for flags updates Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499189651-18797-7-git-send-email-patrick.bellasi@arm.com \
--to=patrick.bellasi@arm.com \
--cc=andresoportus@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelaf@google.com \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tkjos@android.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome