From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752735AbdGHH2V (ORCPT ); Sat, 8 Jul 2017 03:28:21 -0400 Received: from mx3.molgen.mpg.de ([141.14.17.11]:40268 "EHLO mx1.molgen.mpg.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751078AbdGHH2U (ORCPT ); Sat, 8 Jul 2017 03:28:20 -0400 Message-ID: <1499498897.1038.2.camel@molgen.mpg.de> Subject: Re: irq: Invalid fwnode type (2) for irqdomain From: Paul Menzel To: Marc Zyngier , Thomas Gleixner , John Garry Cc: linux-kernel@vger.kernel.org Date: Sat, 08 Jul 2017 09:28:17 +0200 In-Reply-To: <616db264-ba9f-f729-25a9-ee57ee8c2f10@arm.com> References: <1499250919.1353.3.camel@molgen.mpg.de> <616db264-ba9f-f729-25a9-ee57ee8c2f10@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Marc, dear John, Am Donnerstag, den 06.07.2017, 15:21 +0100 schrieb Marc Zyngier: > On 05/07/17 11:41, Thomas Gleixner wrote: > > On Wed, 5 Jul 2017, Paul Menzel wrote: > > > On a Lenovo X60t with coreboot based firmware testing the latest > > > master > > > branch from Linus, the message below is new, and isn’t there with > > > Linux > > > 4.12. > > > > > > ``` > > > irq: Invalid fwnode type (2) for irqdomain > > > ``` > > > > > > `git blame kernel/irq/irqdomain.c` shows, the message is added in > > > commit d59f661 (genirq: Allow fwnode to carry name information > > > only). > > > > > > The commit message describes the warning. > > > > > > > Warn if an invalid node is supplied and treat it like no node. > > > > This > > > > happens e.g. with i2 devices on x86 which hand in an ACPI type > > > > node > > > > which has no interface for retrieving the name. > > > > > > How can I find out, how the ACPI/ASL has to be fixed? > > > > It's not an ACPI/ASL issue. Sorry, if the description and error > > message is > > not clear. That's a kernel internal issue because we have no > > interface yet > > to retrieve the required information. I'll have a look later today. > > I've been reported an issue that is somewhat related to this, Any > chance you could give this[1] a go? I have no way to test it... The commit below indeed made the warning go away. > commit 6bf31c05f2a967e5351a3050ef51c18c8c9ee291 > Author: Marc Zyngier > Date:   Thu Jul 6 14:51:31 2017 +0100 > >     irqdomain: Allow ACPI device nodes to be used as irqdomain identifiers >      >     A number of irqchip implementations are (ab)using the irqdomain >     allocator by passing a fwnode that is neither a FWNODE_OF or >     a FWNODE_IRQCHIP. >      >     This is pretty bad, but it also feels pretty crap to force these >     drivers to allocate their own irqchip_fwid when they already have >     a proper fwnode. >      >     Instead, let's teach the irqdomain allocator about ACPI device >     nodes, and add some lovely name generation code... Tested on >     an arm64 D05 system. >      >     Reported-by: John Garry >     Signed-off-by: Marc Zyngier I wonder if a warning/debug messages could and should still be shown, if a fwnode is neither a FWNODE_OF or a FWNODE_IRQCHIP. Kind regards, Paul > [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/fixes-4.13