mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Byungchul Park <byungchul.park@lge.com>
To: torvalds@linux-foundation.org
Cc: axboe@fb.com, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: [RESEND PATCH] bcache: Don't reinvent the wheel but use existing llist API
Date: Mon, 10 Jul 2017 11:37:29 +0900	[thread overview]
Message-ID: <1499654252-32540-2-git-send-email-byungchul.park@lge.com> (raw)
In-Reply-To: <1499654252-32540-1-git-send-email-byungchul.park@lge.com>

Although llist provides proper APIs, they are not used. Make them used.

Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
 drivers/md/bcache/closure.c | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
index 864e673..1841d03 100644
--- a/drivers/md/bcache/closure.c
+++ b/drivers/md/bcache/closure.c
@@ -64,27 +64,16 @@ void closure_put(struct closure *cl)
 void __closure_wake_up(struct closure_waitlist *wait_list)
 {
 	struct llist_node *list;
-	struct closure *cl;
+	struct closure *cl, *t;
 	struct llist_node *reverse = NULL;
 
 	list = llist_del_all(&wait_list->list);
 
 	/* We first reverse the list to preserve FIFO ordering and fairness */
-
-	while (list) {
-		struct llist_node *t = list;
-		list = llist_next(list);
-
-		t->next = reverse;
-		reverse = t;
-	}
+	reverse = llist_reverse_order(list);
 
 	/* Then do the wakeups */
-
-	while (reverse) {
-		cl = container_of(reverse, struct closure, list);
-		reverse = llist_next(reverse);
-
+	llist_for_each_entry_safe(cl, t, reverse, list) {
 		closure_set_waiting(cl, 0);
 		closure_sub(cl, CLOSURE_WAITING + 1);
 	}
-- 
1.9.1

  reply	other threads:[~2017-07-10  2:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10  2:37 [RESEND PATCH] Don't reinvent the wheel but use existing llilst API Byungchul Park
2017-07-10  2:37 ` Byungchul Park [this message]
2017-07-10  2:37 ` [RESEND PATCH] fput: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-07-10  2:37 ` [RESEND PATCH] mm: " Byungchul Park
2017-07-10  2:37 ` [RESEND PATCH] namespace.c: " Byungchul Park
  -- strict thread matches above, loose matches on Subject: below --
2017-08-07  8:38 [RESEND PATCH] bcache: " Byungchul Park
2017-08-07 10:18 ` Coly Li
2017-08-08  4:12   ` Byungchul Park
2017-08-08  5:28     ` Coly Li
2017-08-08  6:00       ` Byungchul Park
2017-08-08  6:50         ` Coly Li
2017-08-09  6:39         ` Nikolay Borisov
2017-08-09  6:42           ` Byungchul Park
2017-05-12  0:35 Byungchul Park
2017-06-02  2:08 ` Byungchul Park
2017-06-13  0:39   ` Byungchul Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1499654252-32540-2-git-send-email-byungchul.park@lge.com \
    --to=byungchul.park@lge.com \
    --cc=axboe@fb.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®