From: "David S. Miller" <davem@redhat.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: ipv4: 2.4.2: unused static variables
Date: Thu, 22 Feb 2001 17:37:24 -0800 (PST) [thread overview]
Message-ID: <14997.48852.42724.728360@pizda.ninka.net> (raw)
In-Reply-To: <200102221358.f1MDwIH30430@flint.arm.linux.org.uk>
In-Reply-To: <200102221358.f1MDwIH30430@flint.arm.linux.org.uk>
Russell King writes:
> With CONFIG_SYSCTL=n, I get the following warnings:
>
> sysctl_net_ipv4.c:50: warning: `tcp_retr1_max' defined but not used
> sysctl_net_ipv4.c:52: warning: `ip_local_port_range_min' defined but not used
> sysctl_net_ipv4.c:53: warning: `ip_local_port_range_max' defined but not used
>
> These are defined static in sysctl_net_ipv4.c, and appear to only be
> exported via procfs. In other words, you can set them to whatever you
> like and the IPv4 stack couldn't care less.
>
> Why do we have them? If they're not used, can we either eliminate them,
> or else move their definition within the '#ifdef CONFIG_SYSCTL' to
> eliminate the warning?
They aren't set to anything because they are not sysctl
"values", they are sysctl "limits". Ie. they tell the sysctl
layer what legal range the user's setting of a particular sysctl
must reside in.
The fix is to enclose these things in CONFIG_SYSCTL, which I have
done in my tree, thanks for bringing this to my attention.
Later,
David S. Miller
davem@redhat.com
prev parent reply other threads:[~2001-02-23 1:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-22 13:58 Russell King
2001-02-23 1:37 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14997.48852.42724.728360@pizda.ninka.net \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®