From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756754AbdGLG5q (ORCPT ); Wed, 12 Jul 2017 02:57:46 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:36230 "EHLO xavier.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbdGLG5p (ORCPT ); Wed, 12 Jul 2017 02:57:45 -0400 From: Geert Uytterhoeven To: Dan Williams , Andrew Morton Cc: Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH] mm: Mark create_huge_pmd() inline to prevent build failure Date: Wed, 12 Jul 2017 08:57:40 +0200 Message-Id: <1499842660-10665-1-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org With gcc 4.1.2: mm/memory.o: In function `create_huge_pmd': memory.c:(.text+0x93e): undefined reference to `do_huge_pmd_anonymous_page' Converting transparent_hugepage_enabled() from a macro to a static inline function reduced the ability of the compiler to remove unused code. Fix this by marking create_huge_pmd() inline. Fixes: 16981d763501c0e0 ("mm: improve readability of transparent_hugepage_enabled()") Signed-off-by: Geert Uytterhoeven --- Interestingly, create_huge_pmd() is emitted in the assembler output, but never called. --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index cbb57194687e393a..0e517be91a89e162 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -3591,7 +3591,7 @@ static int do_numa_page(struct vm_fault *vmf) return 0; } -static int create_huge_pmd(struct vm_fault *vmf) +static inline int create_huge_pmd(struct vm_fault *vmf) { if (vma_is_anonymous(vmf->vma)) return do_huge_pmd_anonymous_page(vmf); -- 2.7.4