From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934036AbdGLIhP (ORCPT ); Wed, 12 Jul 2017 04:37:15 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:42314 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933951AbdGLIhM (ORCPT ); Wed, 12 Jul 2017 04:37:12 -0400 From: Philipp Rosenberger To: linus.walleij@linaro.org, gnurou@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, Philipp Rosenberger Subject: [PATCH 1/2] gpio: gpio-mxc: Fix: higher 16 GPIOs usable as wake source Date: Wed, 12 Jul 2017 10:36:39 +0200 Message-Id: <1499848600-7233-2-git-send-email-p.rosenberger@linutronix.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1499848600-7233-1-git-send-email-p.rosenberger@linutronix.de> References: <1499848600-7233-1-git-send-email-p.rosenberger@linutronix.de> X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the function gpio_set_wake_irq(), port->irq_high is only checked for zero. As platform_get_irq() returns a value less then zero if no interrupt was found, any gpio >= 16 was handled like an irq_high interrupt was available. On iMX27 for example no high interrupt is available. This lead to the problem that only some gpios (the lower 16) were useable as wake sources. Signed-off-by: Philipp Rosenberger --- drivers/gpio/gpio-mxc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c index 3abea3f..9269225 100644 --- a/drivers/gpio/gpio-mxc.c +++ b/drivers/gpio/gpio-mxc.c @@ -424,6 +424,9 @@ static int mxc_gpio_probe(struct platform_device *pdev) return PTR_ERR(port->base); port->irq_high = platform_get_irq(pdev, 1); + if (port->irq_high < 0) + port->irq_high = 0; + port->irq = platform_get_irq(pdev, 0); if (port->irq < 0) return port->irq; -- 2.1.4