From: Taeung Song <treeze.taeung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Milian Wolff <milian.wolff@kdab.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH v2 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples
Date: Fri, 14 Jul 2017 02:45:44 +0900 [thread overview]
Message-ID: <1499967944-15316-1-git-send-email-treeze.taeung@gmail.com> (raw)
Hello,
Currently the --show-total-period option of perf-annotate
is different from perf-report's.
It has two problem like below:
(Reported by Namhyung Kim and Milian Wolff)
1) Wrong column i.e. 'Percent' (even though using --show-total-period)
2) Show number of samples, not period
So fix this option on both the annotate stdio and TUI browser.
And support --show-nr-samples into perf-anntate
so that it correpond with perf-report's.
The code is available on 'perf/ann-fix-period-v2' branch at
git://github.com/taeung/linux-perf.git
Thanks,
Taeung
v2:
- Separate the first patch into respective paches for easy review (Arnaldo)
- Add a patch to introduce 'struct sym_hist_entry' (Arnaldo)
- disasm__calc_percent() could receive a pointer to a struct sym_hist_entry
instead of two pointer (Arnaldo)
- Add a sym_hist_entry into struct disasm_line_samples (Arnaldo)
- Fix a case that can't switch 'the total period view' to
'the number of samples view' on the annotate TUI browser (Arnaldo)
- Calculate the percentage with 'period', not number of samples
Taeung Song (9):
perf annotate: Introduce struct sym_hist_entry
perf annotate: Properly rename 'sum' to 'total_samples' in struct
sym_hist
perf annotate: Fix wrong --show-total-period option showing number of
samples
perf annotate: Show the proper header when using --show-total-period
perf anntoate browser: Fix the toggle total period view to show
period, not number of samples
perf annotate browser: Show the proper header when using
--show-total-period
perf annotate: Support --show-nr-samples option
perf annotate browser: Support the toggle number of samples with a 'e'
hotkey
perf annotate: Use the sample period when calculating the percentage
tools/perf/builtin-annotate.c | 6 +-
tools/perf/builtin-report.c | 13 ++--
tools/perf/builtin-top.c | 6 +-
tools/perf/ui/browsers/annotate.c | 42 ++++++++++---
tools/perf/ui/gtk/annotate.c | 4 +-
tools/perf/util/annotate.c | 125 ++++++++++++++++++++++++++------------
tools/perf/util/annotate.h | 15 +++--
7 files changed, 148 insertions(+), 63 deletions(-)
--
2.7.4
next reply other threads:[~2017-07-13 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 17:45 Taeung Song [this message]
2017-07-18 16:07 ` Namhyung Kim
2017-07-19 17:05 ` Taeung Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499967944-15316-1-git-send-email-treeze.taeung@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milian.wolff@kdab.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®