From: Mustafa Ismail <mustafa.ismail@intel.com>
To: linux-rdma@vger.kernel.org
Cc: dledford@redhat.com, swise@opengridcomputing.com,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
gregkh@linuxfoundation.org, shiraz.saleem@intel.com
Subject: [PATCH 1/2] RDMA/uverbs: Fix the check for port number
Date: Thu, 13 Jul 2017 14:37:37 -0500 [thread overview]
Message-ID: <1499974658-6180-2-git-send-email-mustafa.ismail@intel.com> (raw)
In-Reply-To: <1499974658-6180-1-git-send-email-mustafa.ismail@intel.com>
The port number is only valid if IB_QP_PORT is set in the mask.
So only check port number if it is valid to prevent modify_qp from
failing due to an invalid port number.
Fixes: 5ecce4c9b17b("Check port number supplied by user verbs cmds")
Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
---
drivers/infiniband/core/uverbs_cmd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
index 8ba9bfb..19de068 100644
--- a/drivers/infiniband/core/uverbs_cmd.c
+++ b/drivers/infiniband/core/uverbs_cmd.c
@@ -1935,7 +1935,8 @@ static int modify_qp(struct ib_uverbs_file *file,
goto out;
}
- if (!rdma_is_port_valid(qp->device, cmd->base.port_num)) {
+ if ((cmd->base.attr_mask & IB_QP_PORT) &&
+ !rdma_is_port_valid(qp->device, cmd->base.port_num)) {
ret = -EINVAL;
goto release_qp;
}
--
2.7.4
next prev parent reply other threads:[~2017-07-13 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 19:37 [PATCH 0/2] Fix modify_qp failure Mustafa Ismail
2017-07-13 19:37 ` Mustafa Ismail [this message]
2017-07-13 20:24 ` [PATCH 1/2] RDMA/uverbs: Fix the check for port number Steve Wise
2017-07-14 6:48 ` Greg KH
2017-07-13 19:37 ` [PATCH 2/2] RDMA/core: Initialize port_num in qp_attr Mustafa Ismail
2017-07-13 20:25 ` Steve Wise
2017-07-14 6:47 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499974658-6180-2-git-send-email-mustafa.ismail@intel.com \
--to=mustafa.ismail@intel.com \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
--cc=stable@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®