From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9A982D8DA3 for ; Fri, 14 Nov 2025 08:49:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763110178; cv=none; b=cDOw8et2AG6Ey2AcqfI8Aoe7x3cQsWG3PmRVhZsH7wJ3YroXYfnBWF3QHrFMdhhvWgdDbk0IyFkj4i056VRIyBfu+Kjnbi7qUaJghBKb7kwApRnBIOE69Igt59ULCGBc59NtPNIyZIYP0ot/9eAEBuuYuZWDMQcUEdoY7a6G99g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763110178; c=relaxed/simple; bh=qhWrVdkJl/bh943Rpg/Moi+ra3osyEZ5mvlznsHPeR0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=K8UCW8z3yes6iLkFnosOhc74CyywpFkN3aXgcx8Mo05wFHUhGexEhQkyupbxQr07cW+lf2yIEo8NTYc9prf5xlx+Oqzuk7L9hD/yCMOcrrPrk65rJrkDIFPUJQgJOnh0anKFtrpFxeME7V10XroCn+k49aobpBEBqvM5Yxex9cs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hY8XsgSq; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hY8XsgSq" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-477442b1de0so11639055e9.1 for ; Fri, 14 Nov 2025 00:49:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763110175; x=1763714975; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=YeYjS1oDyvjSvHSS5QjEowfSx3Ga9VJevXqRCYptZeQ=; b=hY8XsgSqBR0Rp6d2MBEckJb3Ero2aZNqSBZemerRgFB1SL6m2WxoxlfKsUKf/XE2nm 2UTXi9AUxQQWbSOgVZdOuDKXyb418BCjpID2pgWp0w0ucDTIO0SaiUxoPKnlsSK6AOIY /0QM5/gwL9bKwcE+MxLIO4gp5fwmwLcJuqLmkipV8spTzNRvujSWh9jm2cIWpoUQtu+m zQM1InoHGjiCBtJE6nEnXYf4PZ6Cd0uDsXz3wtNGE6JWVxp79ycLtFekBMDJ/ql4AnCF +SFex5vbAeRaec4HbOZo/S2gbddCrQEfAqhbotubEFrsLyTyTOFtL5oRh5gNdm0GMilE xS9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763110175; x=1763714975; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YeYjS1oDyvjSvHSS5QjEowfSx3Ga9VJevXqRCYptZeQ=; b=lPQel7t7CeobCvBs2SraC1KA6sJAjyXKjGcB7ZmxaZJsOOWH51if5Vu+gbmPB2pn53 HNGwK5DfUUtqhftb7UI1pNZ0gjGBQqtoPu5xp3K7aQSWa3PwuadIJ9ESvZLfgq+5vSsN LPIsavUuprw5yhddBo7U0de92LUMrkzRovEsPW9FBZjXf3aa2jBVoyMBXLJ6Awn3wG2F F9VDSMR1ZxmA1JwWm6cX0kJTA9/ni31slnzLUEf6/3LpeQ28Wh7Otnhsz7BjbPTk2n98 TFsMn8pWTESITCtYIW7oKdm0/Zkuy5oyIRHpG/mSSJXgi2w2Vbv3GEx5Am7nyKt+RAiy hr+Q== X-Forwarded-Encrypted: i=1; AJvYcCUzxjvkuZl3QC4zBewLz3eI31eyQ38on51xfHmG+i0/WnYSnOIAZh6ocR9uAJSycmE4Kzf9iLSeyv5XJJk=@vger.kernel.org X-Gm-Message-State: AOJu0YywAPoaMEbgOWHeq+yaqpAgAfp0GuhkxvjPH8vMuiY731Vsh5v6 wjQRGf3VdUCOAd7fsiTYop60QBF4I39mzJPNnCRjqs63R6xvxU1Iq9Rm X-Gm-Gg: ASbGncsdBRj7PcPthVCHNKB3C/BIdhnj9zerHl0Fzv+y1FGM4zqzWmenBoJa+UOPqmm vdvgRHyN0ww3P3QHjwpbCOWkbu+qAX59cQkVeXukxgtmek00o/szxaSSND0p0zRIdoH09ia3Di6 EsNSsZuqFa6FbTE1AJFxKeOyTHMy+r5aS/UCRsxtyPcXMEBY5czLGWajyWzALx+hlEAyHqEQxhW ezniGVQ+2rT5xP8RrjTSFA4Tw2J23hsqeJrqXK5BARw/W+/tR2XuaT9EsWcf9EzfcKbj0/TbWFZ 4D1WgWKlH4fjZfBQcc7rehtq1o0UmvMKH2FfNl8Mb81qlx+k06ixE6PF8HxkqWlCGhurbCRqvbi tFrzylMSyom0maFld7EQ3A0MP5O5YtgVwZXWt5h+3wlEsEyOyZsUBZZUglIkGYKUeQyUVZHIw4z JyQwBLVQRo X-Google-Smtp-Source: AGHT+IEkod5fG6AAsH4ctHoDhGlcXc5CZv0N8Qu+3OArUyWUzrS5cYCQoO9x4HYN//zKqgCfS/g6sg== X-Received: by 2002:a05:600c:c4a1:b0:475:dd7f:f6cd with SMTP id 5b1f17b1804b1-4778fe96c46mr20560365e9.35.1763110174886; Fri, 14 Nov 2025 00:49:34 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4778bb454a6sm40623555e9.2.2025.11.14.00.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Nov 2025 00:49:34 -0800 (PST) Message-ID: <149fcf8e5df47fd94f9596498e9bfd7171cc7c5c.camel@gmail.com> Subject: Re: [PATCH] pwm: adp5585: correct mismatched pwm chip info From: Nuno =?ISO-8859-1?Q?S=E1?= To: ziniu.wang_1@nxp.com, laurent.pinchart@ideasonboard.com, ukleinek@kernel.org, nuno.sa@analog.com, lee@kernel.org Cc: linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Date: Fri, 14 Nov 2025 08:50:12 +0000 In-Reply-To: <20251114065308.2074893-1-ziniu.wang_1@nxp.com> References: <20251114065308.2074893-1-ziniu.wang_1@nxp.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-11-14 at 14:53 +0800, ziniu.wang_1@nxp.com wrote: > From: Luke Wang >=20 > The register addresses of ADP5585 and ADP5589 are reversed. >=20 > Fixes: 75024f97e82e ("pwm: adp5585: add support for adp5589") >=20 > Signed-off-by: Luke Wang > --- Ouch! Thanks for the fix! Acked-by: Nuno S=C3=A1 >=20 > =C2=A0drivers/pwm/pwm-adp5585.c | 4 ++-- > =C2=A01 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/pwm/pwm-adp5585.c b/drivers/pwm/pwm-adp5585.c > index dc2860979e24..806f8d79b0d7 100644 > --- a/drivers/pwm/pwm-adp5585.c > +++ b/drivers/pwm/pwm-adp5585.c > @@ -190,13 +190,13 @@ static int adp5585_pwm_probe(struct platform_device= *pdev) > =C2=A0 return 0; > =C2=A0} > =C2=A0 > -static const struct adp5585_pwm_chip adp5589_pwm_chip_info =3D { > +static const struct adp5585_pwm_chip adp5585_pwm_chip_info =3D { > =C2=A0 .pwm_cfg =3D ADP5585_PWM_CFG, > =C2=A0 .pwm_offt_low =3D ADP5585_PWM_OFFT_LOW, > =C2=A0 .pwm_ont_low =3D ADP5585_PWM_ONT_LOW, > =C2=A0}; > =C2=A0 > -static const struct adp5585_pwm_chip adp5585_pwm_chip_info =3D { > +static const struct adp5585_pwm_chip adp5589_pwm_chip_info =3D { > =C2=A0 .pwm_cfg =3D ADP5589_PWM_CFG, > =C2=A0 .pwm_offt_low =3D ADP5589_PWM_OFFT_LOW, > =C2=A0 .pwm_ont_low =3D ADP5589_PWM_ONT_LOW,