From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender-of-o58.zoho.eu (sender-of-o58.zoho.eu [136.143.169.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7044B14A4CC; Tue, 17 Mar 2026 07:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.169.58 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773732632; cv=pass; b=rfyEYT58Ya+xjmFhCleCMdhWRX9GJl3k/6nSPqch04Ctn2M58hHZI3Y7T2nTJmuLcyHeJ3rid4n4K2l6JPf5ZnYDNvXEKqFFxcdQkkoIzHiZCgV06z94aMwpQ4rHMwKq66WOLig3t8J2bZbWMgxjGL4SAcspu1UEZpT6I4nMisk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773732632; c=relaxed/simple; bh=D3c4Xh4zpsLCaamMqhcM0HWLZ+d2PoNg8Mk0G1MrDS8=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=R9DRs1ra2BsBcTWyaTTuSnWOiL7XCNkyZ1faJdcErUno/rgcMwLzy9n6lxXYf6QYHtJWp6G/3VVwBhAaP9vVGq//KGQmpvRJcLLbcErXIR3PYgdDIshFaR76BOUkAJ2aSARc+LcjVbJcTiY7NFJBTcLFwLNJzp/qFC31B23Nyuc= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=objecting.org; spf=pass smtp.mailfrom=objecting.org; dkim=pass (1024-bit key) header.d=objecting.org header.i=objecting@objecting.org header.b=ZnUevuo6; arc=pass smtp.client-ip=136.143.169.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=objecting.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=objecting.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=objecting.org header.i=objecting@objecting.org header.b="ZnUevuo6" ARC-Seal: i=1; a=rsa-sha256; t=1773732611; cv=none; d=zohomail.eu; s=zohoarc; b=YMaSLX1w1PEszP193fB91ZJQl4zcrkAero64ibKpR0N7zLTakeeN3G/bIZ6mPKXKYoHMaKfJ2+zBhLSqFkIEf+UM+jMCz4s95SkKYatyrqqr08OPeDhcR+W1MjfoN1njEgs3YSeiYqSFnesYvfvP8Wrbds6KdnAvmMT1fQahjRY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1773732611; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=WoOm1OxL0Ki7bqEUe/V/s3OwivpFpxmZq1uOGpe59KE=; b=dFs2Wp+y62rY5ifbMLqw0TqAKRsv/TXNgzDbJjbrFh1qGK5hmm0biiDm/DG2y/MyZ6AK53/q0z3dT3HuVYYKMUGyWIVOg1s+3XDF9BzfNqNGwIuz5q7bzkvf99xwBTQ+o1fFazs3JHsvxDIZLZgXq5Xr4B8UrKb10xB7PZSJKno= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=objecting.org; spf=pass smtp.mailfrom=objecting@objecting.org; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1773732611; s=zmail; d=objecting.org; i=objecting@objecting.org; h=Date:Date:From:From:To:To:CC:Subject:Subject:In-Reply-To:References:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=WoOm1OxL0Ki7bqEUe/V/s3OwivpFpxmZq1uOGpe59KE=; b=ZnUevuo6wSWp8X8S22wJUeEtFdEw3IxE+je7AS/ywYUhjPMnYsIzqjsLazMq53fa k/kiPCxa93p0+SSl0GeTA4+YmkdoRayT1laHD/Sz6AaMAA9zE17tk0zgpvzMTYCy1zS TYzhPYY+sJVsvtzQpqEXpWtRLnJOvTVjIvhEJSM8= Received: by mx.zoho.eu with SMTPS id 1773732610011526.0005314372794; Tue, 17 Mar 2026 08:30:10 +0100 (CET) Date: Tue, 17 Mar 2026 07:30:10 +0000 From: Josh Law To: David Gow , Andrew Morton CC: Brendan Higgins , Rae Moar , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/8] lib/glob: bug fixes, new features, and tests User-Agent: Thunderbird for Android In-Reply-To: References: <20260315211807.411173-1-objecting@objecting.org> Message-ID: <14CA95B8-D56D-4F85-AF40-A8E7061D2A6D@objecting.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External On 17 March 2026 07:19:47 GMT, David Gow wrote: >Hi Josh, > >Le 16/03/2026 =C3=A0 5:17 AM, Josh Law a =C3=A9crit=C2=A0: >> Bug fixes, extensions, and test coverage for lib/glob=2Ec: >>=20 >> Patches 1-3 fix corner cases in the existing glob_match(): >> - Inverted character class ranges like [z-a] are now normalized >> instead of silently failing to match=2E >> - A trailing backslash is treated as a literal '\' rather than >> reading past the end of the pattern string=2E >> - [^=2E=2E=2E] is accepted as an alias for [!=2E=2E=2E] to match the >> regex-style negation syntax documented in glob(7)=2E >>=20 >> Patches 4-5 add two new utility functions: >> - glob_match_nocase() for case-insensitive matching, useful for >> subsystems like ATA that need case-folded denylist comparisons=2E >> - glob_validate() for checking pattern syntax before use, so >> callers can reject malformed patterns early with a clear error=2E >>=20 >> Patches 6-7 add kunit test coverage: >> - 47 new test cases for glob_match covering escapes, inverted >> ranges, caret negation, edge cases, and unclosed brackets=2E >> - 11 test cases for glob_match_nocase=2E >> - 17 test cases for glob_validate=2E >>=20 >> Patch 8 adds a real in-tree caller for glob_validate() in the kunit >> executor, validating user-provided filter_glob patterns and returning >> -EINVAL for malformed ones=2E >>=20 >> Changes since v3: >> - Resend: v3 accidentally included stale v2 patch files in the >> same email thread=2E No code changes from v3=2E >>=20 >> Changes since v2: >> - Fixed missing '^' in __glob_match metacharacter comment (patch 4)= =2E >> - Dropped unnecessary braces in glob_validate case '[' (patch 5)=2E >> - Added real-world example to glob_validate() commit message (patch = 5)=2E >>=20 >> Changes since v1: >> - Added patch 8 (kunit executor caller for glob_validate)=2E >> - Updated glob_match_nocase() commit message to reference the ATA >> denylist as the intended caller (follow-up patch)=2E >>=20 >> Josh Law (8): >> lib/glob: normalize inverted character class ranges >> lib/glob: treat trailing backslash as literal character >> lib/glob: accept [^=2E=2E=2E] as character class negation syntax >> lib/glob: add case-insensitive glob_match_nocase() >> lib/glob: add glob_validate() for pattern syntax checking >> lib/tests: add glob test cases for escapes, edge cases, and new >> features >> lib/tests: add kunit tests for glob_match_nocase() and glob_validate= () >> kunit: validate glob filter patterns before use >>=20 >> include/linux/glob=2Eh | 2 + >> lib/glob=2Ec | 123 ++++++++++++++++++++++++++++++++++++--= -- >> lib/kunit/executor=2Ec | 13 +++++ >> lib/tests/glob_kunit=2Ec | 124 ++++++++++++++++++++++++++++++++++++++= +++ >> 4 files changed, 252 insertions(+), 10 deletions(-) >>=20 > >Thanks: always good to have better test coverage (and those are some nast= y corner cases!) > >Series is: > >Acked-by: David Gow >Tested-by: David Gow > >I'm making the assumption that this is going in via mm-nonmm, not the kse= lftest/kunit tree, as it has dependencies in that branch=2E > >Cheers, >-- David > Cheers David! Have a great day! V/R Josh Law