From: Kumar Gala <galak@codeaurora.org>
To: Sebastian Reichel <sre@debian.org>
Cc: linux-input@vger.kernel.org,
"\"'Benoît Cousson'\"" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <rob.herring@calxeda.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Rob Landley" <rob@landley.net>,
"Russell King" <linux@arm.linux.org.uk>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Grant Likely" <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support
Date: Tue, 29 Oct 2013 03:33:31 -0500 [thread overview]
Message-ID: <14DEC9DA-8C77-4F73-AF3A-6C0D20C6C1AB@codeaurora.org> (raw)
In-Reply-To: <20131029010608.GA5353@earth.universe>
On Oct 28, 2013, at 8:06 PM, Sebastian Reichel wrote:
> On Mon, Oct 28, 2013 at 01:42:47AM -0500, Kumar Gala wrote:
>>> +This binding is based on the matrix-keymap binding with the following
>>> +changes:
>>
>> Maybe be a bit more specific and say 'based on the input/matrix-keymap.txt binding'..
>
> OK.
>
>>> + * keypad,num-rows and keypad,num-columns are required.
>>
>> Is linux,keymap required from matrix-keymap.txt?
>
> Yes, matrix-keymap.txt contains descriptions for the following:
>
> required:
> - linux,keymap
So you don't say that linux,keymap is required for twl4030-keypad (wasn't clear if you assumed that or not).
> optional:
> - keypad,num-rows
> - keypad,num-columns
>
>>> +Optional Properties specific to linux:
>>> +- linux,keypad-no-autorepeat: do no enable autorepeat feature.
>>
>> Does it make sense to update the matrix-keymap.txt binding to add
>> 'linux,keypad-no-autorepeat' there?
>
> At least according to devicetree documentation there are
> keymap-matrix.txt based drivers, which do not support
> "linux,keypad-no-autorepeat".
Which is why it could be optional in keymap-matrix.txt. I dont know anything about keymap/keypad's just asking the question?
It seems as if linux,keypad-no-autorepeat is intended to mean the same thing (if relevant to the device) across all drivers. Is that correct? If so it seems like moving it to be specified in a generic input binding makes sense, just not sure if keymap-matrix.txt is that place or not.
- k
--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2013-10-29 8:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 12:47 [PATCHv2 0/3] Add Nokia N900 DT support Sebastian Reichel
2013-10-22 12:47 ` [PATCHv2 1/3] Input: twl4030-keypad - add device tree support Sebastian Reichel
2013-10-27 11:17 ` Pavel Machek
2013-10-27 11:40 ` Sebastian Reichel
2013-10-27 11:47 ` Pavel Machek
2013-10-27 12:23 ` Tony Lindgren
2013-10-27 16:31 ` Sebastian Reichel
2013-10-30 13:53 ` Grant Likely
2013-10-30 13:59 ` Pavel Machek
2013-10-28 6:42 ` Kumar Gala
2013-10-29 1:06 ` Sebastian Reichel
2013-10-29 8:33 ` Kumar Gala [this message]
2013-10-29 10:25 ` Sebastian Reichel
2013-10-22 12:47 ` [PATCHv2 2/3] DTS: ARM: TWL4030: Add keypad node Sebastian Reichel
2013-10-22 12:47 ` [PATCHv2 3/3] ARM: dts: N900: TWL4030 Keypad Matrix definition Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14DEC9DA-8C77-4F73-AF3A-6C0D20C6C1AB@codeaurora.org \
--to=galak@codeaurora.org \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sre@debian.org \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome