Re: [PATCH] Staging: lusture: Remove an open coded simple_open() function

["Drokin, Oleg" <oleg.drokin@intel.com>]

On Jun 16, 2015, at 3:03 AM, Abdul, Hussain (H.) wrote:

> From: Abdul Hussain <habdul@visteon.com>
> 
> This patch removes an open coded simple_open() function and replace file
> operations references to the function with simple_open() instead
> 
> Signed-off-by: Abdul Hussain <habdul@visteon.com>
> ---
> drivers/staging/lustre/lustre/fld/lproc_fld.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> index b35ff28..d19b724 100644
> --- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> +++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> @@ -143,13 +143,6 @@ fld_debugfs_cache_flush_write(struct file *file, const char __user *buffer,
> }
> 
> static int
> -fld_debugfs_cache_flush_open(struct inode *inode, struct file *file)
> -{
> -	file->private_data = inode->i_private;
> -	return 0;
> -}
> -
> -static int
> fld_debugfs_cache_flush_release(struct inode *inode, struct file *file)
> {
> 	file->private_data = NULL;
> @@ -158,7 +151,7 @@ fld_debugfs_cache_flush_release(struct inode *inode, struct file *file)
> 
> static struct file_operations fld_debugfs_cache_flush_fops = {
> 	.owner		= THIS_MODULE,
> -	.open		= fld_debugfs_cache_flush_open,
> +	.open = simple_open,

Could you please save the indenting to match the rest of this structure assignment?

> 	.write		= fld_debugfs_cache_flush_write,
> 	.release	= fld_debugfs_cache_flush_release,
> };
> -- 
> 1.9.1