From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066AbdIFVTB (ORCPT ); Wed, 6 Sep 2017 17:19:01 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:51655 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752891AbdIFVTA (ORCPT ); Wed, 6 Sep 2017 17:19:00 -0400 X-Auth-Info: IT6jANsUBqCh4UUWiOPYJaSjLKO4kkH9IXQm3f1l8jY= Subject: Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq To: Nicolin Chen Cc: Fabio Estevam , Timur Tabi , Xiubo Li , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "festevam@gmail.com" , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <07e54d28-3bbc-aad2-146b-30867c0bc337@denx.de> <20170905052031.GB2774@Asurada-CZ80> <819784e1-910b-6833-997a-2097e147bd0c@denx.de> <20170905181108.GB23906@Asurada-Nvidia> <20170905225225.GA14132@Asurada-Nvidia> <20170906173348.GA28104@Asurada-Nvidia> <69352458-2e90-a847-2c2f-bba259a32162@denx.de> <20170906194748.GA31334@Asurada-Nvidia> From: =?UTF-8?Q?=c5=81ukasz_Majewski?= Organization: DENX Message-ID: <14a174b2-df3b-73f2-a5c2-7bd4ca9b0882@denx.de> Date: Wed, 6 Sep 2017 23:18:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170906194748.GA31334@Asurada-Nvidia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2017 09:47 PM, Nicolin Chen wrote: > On Wed, Sep 06, 2017 at 08:35:50PM +0200, Łukasz Majewski wrote: > >> clocks = <&clks IMX6QDL_CLK_SSI2_IPG>, >> <&clks IMX6QDL_CLK_SSI2>; >> clock-names = "ipg", "baud"; > >>>> dailink_master: cpu { >>>> sound-dai = <&ssi2>; >>>> clock = <&SSSS>; >> >> If possible I do prefer a solution, which uses only DTS. >> Side question - how to refer to baud clock from [1]? > > Just add a property to this cpu node like: > clock = <&clks IMX6QDL_CLK_SSI2>; Ok. > >>>> system-clock-frequency = ; > > This would not be necessary unless you want to specify a clock rate > so as to override the clock rate configuration in hw_params(). Ok. > >>> This is the right solution based on current simple-card driver. For >>> SSI (having two clocks), you have to specify the baud clock in the >>> cpu node like that. I believe this is what the simple-card designer >>> expected users to do since the cpu node is the first place that the >>> driver tries to look at. >> >> I will give a shoot the option with adding the ipg clock. > > No, not ipg clock. You should use the second clock -- baud clock. Yes. Correct - the baud clock. > -- Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de