From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752076AbbJOJIg (ORCPT ); Thu, 15 Oct 2015 05:08:36 -0400 Received: from solo.fdn.fr ([80.67.169.19]:42196 "EHLO solo.fdn.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbbJOJId (ORCPT ); Thu, 15 Oct 2015 05:08:33 -0400 X-Greylist: delayed 309 seconds by postgrey-1.27 at vger.kernel.org; Thu, 15 Oct 2015 05:08:32 EDT To: Gregory CLEMENT Subject: Re: [PATCH 3.16.y-ckt 053/133] ARM: orion5x: fix legacy orion5x IRQ numbers X-PHP-Originating-Script: 0:main.inc MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 15 Oct 2015 11:03:19 +0200 From: Benjamin Cama Cc: Luis Henriques , Ben Hutchings , , , In-Reply-To: <87vba83b3g.fsf@free-electrons.com> References: <1443606681-7124-1-git-send-email-luis.henriques@canonical.com> <1443606681-7124-54-git-send-email-luis.henriques@canonical.com> <1444879386.31451.42.camel@decadent.org.uk> <87vba83b3g.fsf@free-electrons.com> Message-ID: <14a78331a910eca4ab25bf718a89bee4@dolka.fr> User-Agent: Roundcube Webmail/0.7.2 X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: benoar@dolka.fr X-SA-Exim-Scanned: No (on thinkpad.dolka.fr); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi everyone, Le 2015-10-15 08:22, Gregory CLEMENT a écrit : > On jeu., oct. 15 2015, Ben Hutchings wrote: > >> On Wed, 2015-09-30 at 10:50 +0100, Luis Henriques wrote: >>> 3.16.7-ckt18 -stable review patch.  If anyone has any objections, >>> please let me know. >>> >>> ------------------ >>> >>> From: Benjamin Cama >>> >>> commit 5be9fc23cdb42e1d383ecc8eae8a8ff70a752708 upstream. >>> >>> Since v3.18, attempts to deliver IRQ0 are rejected, breaking >>> orion5x. >> [...] >> >> But I don't think this was needed for 3.16-ckt, was it? > > Indeed it fixes a commit (a71b092a9c68 ("ARM: Convert handle_IRQ to > use > __handle_domain_irq")) that was introduced in 3.18: > > git tag --contains a71b092a9c68 | grep "^v3\." | sort | head -1 > v3.18 > > So please Luis do not apply it on 3.16-ckt unless you already back > port > the commit a71b092a9c68 ("ARM: Convert handle_IRQ to use > __handle_domain_irq") on this branch. Indeed it is not completely needed, but to be clear it "just" shifts the IRQs by one, so it shouldn't do any harm either. So it is up to you. I would understand that you choose not to apply it to be on the safe side. BTW, it seems f28d7de is required by my patch, appearing in 3.14; as I don't follow kernel development closely, I could not assure you my patch is completly safe for 3.16. Regards, -- benjamin