From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754631AbeAHRpN (ORCPT + 1 other); Mon, 8 Jan 2018 12:45:13 -0500 Received: from mail-io0-f193.google.com ([209.85.223.193]:44425 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbeAHRpK (ORCPT ); Mon, 8 Jan 2018 12:45:10 -0500 X-Google-Smtp-Source: ACJfBouIKhsHXQAivbEPCDuRbuM0CHKwOsQuqE6QFqJWlLG4Y1KG/8kGUUHogyYidBkCshZIA5Xj6Q== Subject: Re: [greybus-dev] [PATCH v2] Staging: greybus: camera: cleanup multiple checks for null pointers To: Sumit Pundir , johan@kernel.org Cc: devel@driverdev.osuosl.org, elder@kernel.org, linux-kernel@vger.kernel.org, greybus-dev@lists.linaro.org References: <1515430215-8826-1-git-send-email-pundirsumit11@gmail.com> From: Alex Elder Message-ID: <14aa0ddb-8600-a0af-5d42-ed5be55c27f1@linaro.org> Date: Mon, 8 Jan 2018 11:44:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1515430215-8826-1-git-send-email-pundirsumit11@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/08/2018 10:50 AM, Sumit Pundir wrote: > Fixed coding style issue regarding null comparison at multiple lines. > Issue reported by checkpatch.pl > > Signed-off-by: Sumit Pundir Looks good. The subject should say "staging" rather than "Staging" but that's probably not a big deal. Reviewed-by: Alex Elder > --- > v2: > Updated the patch title and description. > > drivers/staging/greybus/camera.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c > index f13f16b..07ebfb8 100644 > --- a/drivers/staging/greybus/camera.c > +++ b/drivers/staging/greybus/camera.c > @@ -918,7 +918,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, > > /* Retrieve number of streams to configure */ > token = strsep(&buf, ";"); > - if (token == NULL) > + if (!token) > return -EINVAL; > > ret = kstrtouint(token, 10, &nstreams); > @@ -929,7 +929,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, > return -EINVAL; > > token = strsep(&buf, ";"); > - if (token == NULL) > + if (!token) > return -EINVAL; > > ret = kstrtouint(token, 10, &flags); > @@ -946,7 +946,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, > > /* width */ > token = strsep(&buf, ";"); > - if (token == NULL) { > + if (!token) { > ret = -EINVAL; > goto done; > } > @@ -956,7 +956,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, > > /* height */ > token = strsep(&buf, ";"); > - if (token == NULL) > + if (!token) > goto done; > > ret = kstrtouint(token, 10, &stream->height); > @@ -965,7 +965,7 @@ static ssize_t gb_camera_debugfs_configure_streams(struct gb_camera *gcam, > > /* Image format code */ > token = strsep(&buf, ";"); > - if (token == NULL) > + if (!token) > goto done; > > ret = kstrtouint(token, 16, &stream->format); > @@ -1009,7 +1009,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam, > > /* Request id */ > token = strsep(&buf, ";"); > - if (token == NULL) > + if (!token) > return -EINVAL; > ret = kstrtouint(token, 10, &request_id); > if (ret < 0) > @@ -1017,7 +1017,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam, > > /* Stream mask */ > token = strsep(&buf, ";"); > - if (token == NULL) > + if (!token) > return -EINVAL; > ret = kstrtouint(token, 16, &streams_mask); > if (ret < 0) > @@ -1025,7 +1025,7 @@ static ssize_t gb_camera_debugfs_capture(struct gb_camera *gcam, > > /* number of frames */ > token = strsep(&buf, ";"); > - if (token == NULL) > + if (!token) > return -EINVAL; > ret = kstrtouint(token, 10, &num_frames); > if (ret < 0) >