From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 016B5390214 for ; Wed, 4 Mar 2026 11:14:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622883; cv=none; b=OW501kOGKu4mRrsnrL73uyLt/xTYqhHKc6gCrHT/n/Ol8hhWJKTZymMnrFW0fSUDATQVJmKKREeX8YVmTJMwzB3n1P+/jpyMYXenIlBPYXBDdVhUEQE9SZ4GilhHaqMaGRV1mTMyc6a2RYMsbuQW7CsarvOPAUIXm37f6ylFxlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772622883; c=relaxed/simple; bh=6TGX5eb8szacsm3F2lalvCDnlz7m3TVT+pByVabyND8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ISEmUZ9TLkFWXtW3kWbqHY7hsJLCr9KvOiD4TlhkCIqGS20USK2lL7Nd+SA5bD/5kytvCLKg/WIEnKws41aC5T8BlvmLY3kxp1v4LUvSdUOfF4+1idv04hCoV8Uodm3Sj4ouOUMfHP9hDhzGBWfxtHcJI9S7+zhX16wUSg/zo0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZfszIOMH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=epR9SHyq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZfszIOMH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="epR9SHyq" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6245Sd7m2861318 for ; Wed, 4 Mar 2026 11:14:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0rGH/jrADNsbgLFFgLkWWPcPeim09mgivrA/vZM8rJI=; b=ZfszIOMHKp6J40jg oBrF4ZuPUGXDoxCpYm06ffM12zLkZVk1krzE32N1D8vdreRK8ZYpYRtXkLLH93Df J3UnpJLRwdoO8u8ax7RwJ2rMT+pC5DeMq0aIJbqPEJUbt8rH4saAllREexOk+RZo n2xfNBA0jP8Em5OS0195UXKEHHGX4OfAmvHQj1FluVG7FuToacmn+2e4QtEICzZv wJsx2eJW6Mycgrq5Fy9dCHHfafq/dlwhP+Tar2gEnim2rwWob6OSLo4bhCVYJau5 sN0gGELSwnmwj5P6Tg/LAkJn3DwDRAaavp21sNihCLJtpCMSJYqETKq7mIxd3cKm 4G4fXA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cp2c9kp5f-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2026 11:14:40 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb3ad1b81aso2484385a.2 for ; Wed, 04 Mar 2026 03:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772622880; x=1773227680; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0rGH/jrADNsbgLFFgLkWWPcPeim09mgivrA/vZM8rJI=; b=epR9SHyqiPEUankjwQGRYP8oYpj/CihYu8iU6TP5oDX+mwsD609B7bbZcDul8PObUh yLYzCRUmJBH5yeu5EIZUJrgWZAQAJNshUb/Z6rL0RPWOvBBcAaW5MWvOyKSgFAgqs9vJ qePXD8ztjsTgibGDe3LHnaj1ajyvb6ousHVWpiaA7JtpTil9D8P5gQqOqgob4NREjzR1 RZMG8qmbXxo34vJhHMaWZStv/E04SAE5sngbe+KIMQViFmqGSjclvtSi3sPc9lQvMbZt AbLXo5EcmN5G7TyBQsEFmFgxtNjaEPPC6yVk/Mu0bys6uIL/wuL/j3vHaGUv1ZqdaGvD J43w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772622880; x=1773227680; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0rGH/jrADNsbgLFFgLkWWPcPeim09mgivrA/vZM8rJI=; b=sjSgDxfxAvuQean5KRvUN3/BP5GbgkGw4Ny8ipaLZ1f0lYp7tBikqsU0zB7ASG9pAj 0FeN9H4ZHVqvD7SqWV3+igczZlzichz71sduhKXR5puMeOGJjtC8tdFuFrWSJF9GQ990 NsRUHv52X7MWqhj37sPMp/tSiXVpKCMxfJWtAsWGsfROykbf/rTraGP2AXrGjlamGBp3 tYVxULonicjBZQO5IU2NqlgaGRTRwlop4DcdkWIm0DAE6ujh9++0uzTP7Uyh9Jhhhkeu um/c8I8mHlPkCO1MxZGr2rZ+jflsGZ5xBrjum8eLhwsunzGBRg768MB0MrP43Bm+Xr2P +q2w== X-Forwarded-Encrypted: i=1; AJvYcCVlYta0uKEsRHA54GcXTnS2DCzdC7hYQD1xApN0rXGNPclub8gf3KEFDn6pLnNnRAeDXkU3q4Q1Bs26+us=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc/XgTslEQI0MO/9dM2ulPj+HsEJbGMqqs/IlNU6XTcV5+dbsz Dp4AhKLIASbdlJhC5ENVLqV2u2Lt2OkHRUG12ExHUxHX8Ds8g8g3kbqSay7qczql9z6XUf0DQW+ 4yL4fFMGdpzhUNhLrpIKqI0n6EaxB1aNoN9bsD40jQYeJz+N6/lcxgUFeAPYj4Pnjqrc= X-Gm-Gg: ATEYQzwFkJPwv8kHCtZ9OOX/fEiiwaTl6mG4ZDfjLzt/aHOIPgMg7dyIms6BhVZNNJI QBSCvlCvUp1wuylP11Gr/m1LlbD2DSDZaLOLV/Lae+JyZ9Wu1VMKfxm/oYtslUOs0L+lU0dlLhk YvxM+hjOw0ZVG+m7tepUB8Il428ujcpMGZGM2/Ox2V7VXMhk6zOyF9o+qj92G9EjI4/L898qgqO J380nzeRDlgWZCtdby3SbckfJr7FH0OH+yH0Uf2LNwBfkG40rn1qjHKFOoKOLMXjK6DZhZ7IShj WMm/1gLPzRyXVi+jHQwvaWFEcjYXxDNGDDNI+WfaTPjA01q/edyZPWKqcNfDSziXoPcQ6NDJKjj FKruYh9MeoIed/7PfKwsjimhn1PXtYXHqJH1eoe0EZhaaiypm X-Received: by 2002:a05:620a:46ab:b0:8ca:1107:1215 with SMTP id af79cd13be357-8cd5aed6d97mr172218985a.9.1772622880279; Wed, 04 Mar 2026 03:14:40 -0800 (PST) X-Received: by 2002:a05:620a:46ab:b0:8ca:1107:1215 with SMTP id af79cd13be357-8cd5aed6d97mr172215385a.9.1772622879860; Wed, 04 Mar 2026 03:14:39 -0800 (PST) Received: from [192.168.68.114] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-439c65e0b23sm6002048f8f.32.2026.03.04.03.14.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 03:14:39 -0800 (PST) Message-ID: <14abc647-25c0-449f-a4f0-978372ae5544@oss.qualcomm.com> Date: Wed, 4 Mar 2026 11:14:38 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/14] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add Senary MI2S port To: Krzysztof Kozlowski Cc: broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mohammad.rafi.shaik@oss.qualcomm.com, linux-sound@vger.kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, johan@kernel.org, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, srini@kernel.org References: <20260223180740.444311-1-srinivas.kandagatla@oss.qualcomm.com> <20260223180740.444311-10-srinivas.kandagatla@oss.qualcomm.com> <20260224-ethereal-koala-of-health-eab910@quoll> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260224-ethereal-koala-of-health-eab910@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA0MDA4OCBTYWx0ZWRfX/966KFnf858+ /oAnX04Ro3gy0h6QEk05uw3/P5kRPowbHqDkJSd1fhmV5XQjFjrdm/yxumFXA5fSOjOzAx7nwxl Lpr/5r/Q2oxBAYMcz2mH/3H4T+VRU54+yqTm+PP8gRdEuVz9++WuuVQiaaLJRt11Jmn92dEsrUO BUxQAKxNy0gMGFywVCcgnUgqRgs37ZgJcd0oaH0H/xw38aRSxYWrDYhdqNYuFVGPBc3rE7nLjZs FgQ3A6y5vO5VisbmWLtV9KV5TqFVHRj0/D+bY6nq4jatG5Uv4G6+//dIET4gIBoqqjcqSz5yX5Z /RJk2J/yYUyaFzuo3t4r1ulZoI+uGN64yjWC0TTwRdPWqFGoKzKhhTBVoVuWso0SeDsz0blVBXQ 9JJGAvdDEueB6p6sPjfDl+spPAU+w0Fyt1z9c9teNXcZrdprGH1PVgnRCFVNvvLSmMJxVJ4zalR MRjZNE/HBcOJRebXzLg== X-Proofpoint-ORIG-GUID: 2Ta3T4X0fwnCXTumlLCmP55dKAfjmkuI X-Proofpoint-GUID: 2Ta3T4X0fwnCXTumlLCmP55dKAfjmkuI X-Authority-Analysis: v=2.4 cv=EefFgfmC c=1 sm=1 tr=0 ts=69a81420 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=OoQJ-9uZOr_G_Hsk2v0A:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-04_05,2026-03-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603040088 On 2/24/26 7:14 AM, Krzysztof Kozlowski wrote: > On Mon, Feb 23, 2026 at 06:07:35PM +0000, Srinivas Kandagatla wrote: >> From: Mohammad Rafi Shaik >> >> Qualcomm platforms support the Senary MI2S interface for audio playback >> and capture. Add a new definitions for the Senary MI2S RX and TX ports, >> which are required for boards that utilize the Senary MI2S interface >> for audio routing. >> >> Signed-off-by: Mohammad Rafi Shaik >> Signed-off-by: Srinivas Kandagatla >> --- >> include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h | 2 ++ >> sound/soc/qcom/common.h | 2 +- >> 2 files changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h >> index e27a31ece1f2..45850f2d4342 100644 >> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h >> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h >> @@ -150,6 +150,8 @@ >> #define LPI_MI2S_TX_3 144 >> #define LPI_MI2S_RX_4 145 >> #define LPI_MI2S_TX_4 146 >> +#define SENARY_MI2S_RX 147 >> +#define SENARY_MI2S_TX 148 >> >> #define LPASS_CLK_ID_PRI_MI2S_IBIT 1 >> #define LPASS_CLK_ID_PRI_MI2S_EBIT 2 >> diff --git a/sound/soc/qcom/common.h b/sound/soc/qcom/common.h >> index 85ca73408151..ee6662885593 100644 >> --- a/sound/soc/qcom/common.h >> +++ b/sound/soc/qcom/common.h >> @@ -7,7 +7,7 @@ >> #include >> #include >> >> -#define LPASS_MAX_PORT (LPI_MI2S_TX_4 + 1) >> +#define LPASS_MAX_PORT (SENARY_MI2S_TX + 1) > > Same problem as v1. You already changed this. Don't change the same line > multiple times. > > Anyway, this belongs to the code patch which uses the new LPASS_MAX_PORT > (e.g. ues new SENARY bindings). I understand your concern the reason this was changed in same series is because the patches are from different team members and I did want to keep them separate. I was also hoping that this patch would provide a reference to anyone who is adding new ports, so that they do not forget to update MAX_PORT. I will move the defination of max to last patch, also remove this change as part of dt-bindings patch. --srini > > Best regards, > Krzysztof >