mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: Eric Ren <renzhengeek@gmail.com>, linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, vbabka@suse.cz, ziy@nvidia.com
Subject: Re: [PATCH v2] virtio_mem: fix panic on mb_states indexing overflow
Date: Tue, 21 Dec 2021 14:53:08 +0100	[thread overview]
Message-ID: <14ac1cb4-1cf0-03a3-d412-c35fa9eeea59@redhat.com> (raw)
In-Reply-To: <c7f5f829-5f2f-0c57-0599-6fc20fc8f1d7@gmail.com>

Hi Eric,

> _vm->sbm.first_mb_id == 0

^ that's precisely what I meant.

How could it *ever* be safe on x86-64 to let a virtio-mem device start
on physical address 0, eventually overlapping essentially all DMA, the
BIOS and the PCI hole.

Thus my question: Is this a "fix" for x86-64 or is this a "prepare for"
for !x86-64 (e.g., arm64).

If it's a fix, we want proper "Fixes:" and "Cc: stable" tags. But I
assume this is much rather a preparation for another architecture than
x86-64.

Thanks!

-- 
Thanks,

David / dhildenb


  reply	other threads:[~2021-12-21 13:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20 13:18 Eric Ren
2021-12-20 14:15 ` David Hildenbrand
2021-12-21 12:39   ` Eric Ren
2021-12-21 13:53     ` David Hildenbrand [this message]
2021-12-21 14:24       ` Eric Ren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14ac1cb4-1cf0-03a3-d412-c35fa9eeea59@redhat.com \
    --to=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=renzhengeek@gmail.com \
    --cc=vbabka@suse.cz \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®