From: Timur Tabi <ttabi@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
"lossin@kernel.org" <lossin@kernel.org>,
"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"alex.gaynor@gmail.com" <alex.gaynor@gmail.com>,
"tmgross@umich.edu" <tmgross@umich.edu>,
"daniel.almeida@collabora.com" <daniel.almeida@collabora.com>,
"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
"will@kernel.org" <will@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"rafael@kernel.org" <rafael@kernel.org>,
"gary@garyguo.net" <gary@garyguo.net>,
"dakr@kernel.org" <dakr@kernel.org>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH v3 2/7] rust: io: always inline functions using build_assert with arguments
Date: Wed, 14 Jan 2026 19:26:41 +0000 [thread overview]
Message-ID: <14af917dab28321a69b81765d81d33aa4616bce5.camel@nvidia.com> (raw)
In-Reply-To: <20251208-io-build-assert-v3-2-98aded02c1ea@nvidia.com>
On Mon, 2025-12-08 at 11:47 +0900, Alexandre Courbot wrote:
> `build_assert` relies on the compiler to optimize out its error path.
> Functions using it with its arguments must thus always be inlined,
> otherwise the error path of `build_assert` might not be optimized out,
> triggering a build error.
>
> Cc: stable@vger.kernel.org
> Fixes: ce30d94e6855 ("rust: add `io::{Io, IoRaw}` base types")
> Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Tested-by: Timur Tabi <ttabi@nvidia.com>
Without patch 2/7, my Turing patchset will fail to compile with CLIPPY. So please merge this
patchset, or at least just this patch, soon.
next prev parent reply other threads:[~2026-01-14 19:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 2:46 [PATCH v3 0/7] rust: build_assert: document and fix use with function arguments Alexandre Courbot
2025-12-08 2:46 ` [PATCH v3 1/7] rust: build_assert: add instructions for " Alexandre Courbot
2025-12-08 2:47 ` [PATCH v3 2/7] rust: io: always inline functions using build_assert with arguments Alexandre Courbot
2026-01-14 19:26 ` Timur Tabi [this message]
2025-12-08 2:47 ` [PATCH v3 3/7] rust: cpufreq: " Alexandre Courbot
2025-12-08 13:55 ` Gary Guo
2025-12-09 0:52 ` Alexandre Courbot
2025-12-09 12:02 ` Gary Guo
2025-12-09 1:01 ` Miguel Ojeda
2025-12-15 5:06 ` Viresh Kumar
2025-12-15 11:14 ` Gary Guo
2025-12-16 6:48 ` Viresh Kumar
2025-12-08 2:47 ` [PATCH v3 4/7] rust: bits: " Alexandre Courbot
2025-12-08 2:47 ` [PATCH v3 5/7] rust: sync: refcount: " Alexandre Courbot
2026-01-15 7:49 ` Miguel Ojeda
2026-01-15 8:40 ` Boqun Feng
2025-12-08 2:47 ` [PATCH v3 6/7] rust: irq: " Alexandre Courbot
2025-12-08 2:47 ` [PATCH v3 7/7] rust: num: bounded: add missing comment for always inlined function Alexandre Courbot
2025-12-08 13:49 ` [PATCH v3 0/7] rust: build_assert: document and fix use with function arguments Gary Guo
2025-12-09 0:54 ` Alexandre Courbot
2026-01-14 19:37 ` Danilo Krummrich
2026-01-18 19:45 ` Miguel Ojeda
2026-01-19 8:19 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14af917dab28321a69b81765d81d33aa4616bce5.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mark.rutland@arm.com \
--cc=ojeda@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®