From: Guenter Roeck <linux@roeck-us.net>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
linux-hwmon@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (lm90) Use worker for alarm notifications
Date: Wed, 29 Jun 2022 14:18:11 -0700 [thread overview]
Message-ID: <14b0ee4f-a12f-ccf2-633a-470be3cdfa38@roeck-us.net> (raw)
In-Reply-To: <ba43ed2c-0290-ca5b-ab4b-1f25dad9d882@collabora.com>
On 6/29/22 13:02, Dmitry Osipenko wrote:
> On 6/29/22 18:42, Guenter Roeck wrote:
>> Reporting alarms using hwmon_notify_event() may result in a callback
>> from the thermal subsystem. This means that such notifications must
>> not hold the update lock to avoid a deadlock. To avoid this situation,
>> use a worker to handle notifications.
>>
>> Reported-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Fixes: e182cf579f0f ("hwmon: (lm90) Rework alarm/status handling")
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> Dmitry,
>>
>> can you give this patch a try in your system ?
>
> It works, thanks!
>
> Tested-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>
Thanks a lot for testing!
Guenter
prev parent reply other threads:[~2022-06-29 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 15:42 Guenter Roeck
2022-06-29 20:02 ` Dmitry Osipenko
2022-06-29 21:18 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14b0ee4f-a12f-ccf2-633a-470be3cdfa38@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dmitry.osipenko@collabora.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®