From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Mathieu Malaterre <malat@debian.org>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/32s: Include <linux/moduleloader.h> header file to fix a warning
Date: Thu, 23 May 2019 08:54:14 +0200 [thread overview]
Message-ID: <14b3a3c9-acbd-67b4-9187-912bb1be887f@c-s.fr> (raw)
In-Reply-To: <20190523064956.29008-1-malat@debian.org>
Le 23/05/2019 à 08:49, Mathieu Malaterre a écrit :
> In commit 2edb16efc899 ("powerpc/32: Add KASAN support") support for
> KASAN has been added. However building it as module leads to (warning
> treated as error with W=1):
>
> arch/powerpc/mm/kasan/kasan_init_32.c:135:7: error: no previous prototype for 'module_alloc' [-Werror=missing-prototypes]
>
> Make sure to include <linux/moduleloader.h> to provide the following
> prototype: module_alloc.
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>
Fixes: 2edb16efc899 ("powerpc/32: Add KASAN support")
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> arch/powerpc/mm/kasan/kasan_init_32.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/mm/kasan/kasan_init_32.c b/arch/powerpc/mm/kasan/kasan_init_32.c
> index 0d62be3cba47..0c31e440d094 100644
> --- a/arch/powerpc/mm/kasan/kasan_init_32.c
> +++ b/arch/powerpc/mm/kasan/kasan_init_32.c
> @@ -7,6 +7,7 @@
> #include <linux/memblock.h>
> #include <linux/sched/task.h>
> #include <linux/vmalloc.h>
> +#include <linux/moduleloader.h>
> #include <asm/pgalloc.h>
> #include <asm/code-patching.h>
> #include <mm/mmu_decl.h>
>
prev parent reply other threads:[~2019-05-23 6:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-23 6:49 Mathieu Malaterre
2019-05-23 6:54 ` Christophe Leroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14b3a3c9-acbd-67b4-9187-912bb1be887f@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=malat@debian.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®