From: Peter Rosin <peda@axentia.se>
To: Luca Ceresoli <lucaceresoli77@gmail.com>, linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Luca Ceresoli <luca@lucaceresoli.net>
Subject: Re: [PATCH RESEND] i2c: mux: pca954x: simplify code to reach the adapter
Date: Mon, 1 Oct 2018 13:49:10 +0200 [thread overview]
Message-ID: <14ba57eb-0647-5dca-8f84-eaa27fd0af4a@axentia.se> (raw)
In-Reply-To: <20180926083534.21999-1-lucaceresoli77@gmail.com>
On 2018-09-26 10:35, Luca Ceresoli wrote:
> From: Luca Ceresoli <luca@lucaceresoli.net>
>
> struct i2c_client has a direct pointer to the adapter, no need to dig
> it out of the struct device tree.
Right, looks sane, but can you please also do the same thing for the
ltc4306 and mlxcpld drivers which have the same pattern?
Cheers,
Peter
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
>
> Sorry for the RESEND noise, but my provider and vger are not
> interacting (again). I'll solve the issue at its root ASAP, but in the
> meanwhile I'm sending from a different account.
>
> drivers/i2c/muxes/i2c-mux-pca954x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index 24bd9275fde5..bfabf985e830 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -347,7 +347,7 @@ static void pca954x_cleanup(struct i2c_mux_core *muxc)
> static int pca954x_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> - struct i2c_adapter *adap = to_i2c_adapter(client->dev.parent);
> + struct i2c_adapter *adap = client->adapter;
> struct pca954x_platform_data *pdata = dev_get_platdata(&client->dev);
> struct device *dev = &client->dev;
> struct device_node *np = dev->of_node;
>
next prev parent reply other threads:[~2018-10-01 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 8:35 Luca Ceresoli
2018-10-01 11:49 ` Peter Rosin [this message]
2018-10-01 20:44 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14ba57eb-0647-5dca-8f84-eaa27fd0af4a@axentia.se \
--to=peda@axentia.se \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=lucaceresoli77@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®