mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: duoming@zju.edu.cn
To: "Jakub Kicinski" <kuba@kernel.org>
Cc: linux-hams@vger.kernel.org, ralf@linux-mips.org,
	davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] netrom: fix sleep in atomic context bugs in timer handlers
Date: Tue, 26 Jul 2022 11:20:25 +0800 (GMT+08:00)	[thread overview]
Message-ID: <14bac17c.5d665.182388522da.Coremail.duoming@zju.edu.cn> (raw)
In-Reply-To: <20220725194930.44ca1518@kernel.org>

Hello,

On Mon, 25 Jul 2022 19:49:30 -0700 Jakub Kicinski wrote:

> On Sat, 23 Jul 2022 11:56:46 +0800 Duoming Zhou wrote:
> > Fixes: eafff86d3bd8 ("[NETROM]: Use kmemdup")
> 
> That's not a correct Fixes tag, acme just swapped kmalloc for kmemdup().
> The allocate flags did not change.

Thanks for your time and reply!

The correct Fixes tag is "Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")".
The following is the code:

https://elixir.bootlin.com/linux/v2.6.12-rc2/source/net/netrom/nr_route.c#L158

...
if ((nr_neigh->digipeat = kmalloc(sizeof(*ax25_digi), GFP_KERNEL)) == NULL) {
...

Best regards,
Duoming Zhou



      reply	other threads:[~2022-07-26  3:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-23  3:56 Duoming Zhou
2022-07-26  2:49 ` Jakub Kicinski
2022-07-26  3:20   ` duoming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14bac17c.5d665.182388522da.Coremail.duoming@zju.edu.cn \
    --to=duoming@zju.edu.cn \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-hams@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®