From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C81171EF367 for ; Fri, 28 Feb 2025 15:06:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740755191; cv=none; b=iKJ7AxPrngCrXFiT07o9ip5VOK7kwcoDAKDF6HM5hRlglK67lwAyotOAwA0KblaH2WOqTrlAiAg+VVOCARmZpD+cu89CkUwf0rKRVyE1jEtkviY5ArlcwXi9sb7YRsxZWAZ9mu8oY7XCUNiyz4EZWnxotKlzaNK9g94BtTxquuk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740755191; c=relaxed/simple; bh=olVrCQ7UdaQjy46v5P/GSEQYTGRyn0iXsncNea20IsI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JCeW4VHT8tPO1xlL+7/J2sP8i+huSEyfKxkSRv7zAels5kvY1qa4mheG/p7ac/XBVEkgeCwAXmiAhmS23j7uABHabxNLExZO7wsj17sqRikF9QKPq9TTnlzlYWRpkFVsNmsmiu1tv76tcPYPLn2m/RECtmCs0dZCWv/8ZmWDsGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu; spf=fail smtp.mailfrom=g.harvard.edu; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b=aKrCgxB2; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=g.harvard.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rowland.harvard.edu header.i=@rowland.harvard.edu header.b="aKrCgxB2" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-471f257f763so20802471cf.0 for ; Fri, 28 Feb 2025 07:06:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rowland.harvard.edu; s=google; t=1740755189; x=1741359989; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Sdm5h7ySdGHF2dP5ZUS41EvuGX6rO7bkR29o37l7ikc=; b=aKrCgxB2JmK6oMIaK9/FrZeSLggxm0+91KbaRl/CZbX7bdicpiA8M3C2glgdpE3goa A3M9Gq2fLSZeJc7bkn45adheA7QTlV0NVQ0SZH3c6BEnP+cPUGec8QuLdHI6n9f6dvux SiwCa+yOF0JNKRZCeIzzSq6G7Ro98VkvL4C+4rf6yms2cqWDaSQGEwnpyU5zeftjHWPM cgXATCAhQaSc9ys4XtGhOxQNYhnhleT376kAsTjRFUMUPpR4oNM+CVEOIOfKkKgPrtR6 zZ5W4uY4P2hCRNK0b6kUVpIbDIY8PIsnymnim53vXGnDOseiAO8KHK8SM+G2xP2SHw5p QWYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740755189; x=1741359989; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sdm5h7ySdGHF2dP5ZUS41EvuGX6rO7bkR29o37l7ikc=; b=kVZlzi7T+BZEIQfJahPtQU29ki8O84A2lvF/P2uOh9V5R6J7BoR1/oqsyBCgHRbOnp 3cOuKJ/juC/0iwvxN2EbUCbPV59dw322C0DyWzMZtkD97nKVbumjHPqQxaDP2Attx3vh XO7GpLrdXj/pfacaBmgUEmTR1EhgfQkXUMh3KrQs7UjnX/1VNbLDGWI/HGQRN/zsQMc5 LyXPUtUHWZsi+Twh/istdR8HKAVxnGJde6Md9rSJ6FCxpXuzGA4nKpx1twdeD1EpYe3+ LAa+jrHUI6rvC4afiJ7jE690Lu1kBXZdosW8Vam9LpcDqSpo7awAIe2ulQV2GGpFHGGj 87fg== X-Forwarded-Encrypted: i=1; AJvYcCV2BH/du1DBZYpTcjizsADon+OxeivV5oBIrW+Tox67zZFKy73V8xHw7YA+jWMcKp/iQjo1ALI+CT9ykBM=@vger.kernel.org X-Gm-Message-State: AOJu0YwQY9GwGUTTXfStPPJtFchnkx0j1cHjLIz45FooCOjFmUWVORzI F+7Afs113mJGP1tmku5BzS8lfUTxmb0M0N38ffNKdCBm+37u9lco8FlgOizTDQ== X-Gm-Gg: ASbGncu8jviRW2suI63uOnYcfBJMbB8pElgPqXvWz/L3vdN1wQngzyIhDV/9HV6CAu+ bkJkzGbmHDNbd7jwVV730ySmyjuXp9bAfG3NshyZ3or0Ot2JeHSTQfS6Lw+wlLUWb4IfyOK9hAR g9CYkxh+qAMKpUPdQhA+ptNGk8YJGklNsLXv1FoKCO6qVcgrUjq7or4Gntn1nxtgUecOsQAw7jK TWpjRFeP2x0wxvdtGmHPFby5npAu/Y6WAe9RiW1S6BjC0kPIggw/oT7po7aC5RzU4v/HdfrP0ef akIvO0zumfi5fvqMw9yNkEfgufDeKgJAufL7UY5kWD9LPF5Ibcup7/FnH9p1m49wcIyVREZGqSB 9gmEgdANM+6VC7/gujug= X-Google-Smtp-Source: AGHT+IHfWvDK9PeEa52zO3qX3pzdLJiMyo31UITfvvHt1/OXvd6ktHhMaHffVTjDOsAmO6gnooeXIg== X-Received: by 2002:a05:622a:1994:b0:471:c042:7757 with SMTP id d75a77b69052e-474bc0979bbmr56949661cf.31.1740755188473; Fri, 28 Feb 2025 07:06:28 -0800 (PST) Received: from rowland.harvard.edu (nat-65-112-8-24.harvard-secure.wrls.harvard.edu. [65.112.8.24]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-474691a1d9dsm25621241cf.6.2025.02.28.07.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2025 07:06:27 -0800 (PST) Date: Fri, 28 Feb 2025 10:06:24 -0500 From: Alan Stern To: Pawel Laszczak Cc: "gregkh@linuxfoundation.org" , "krzysztof.kozlowski@linaro.org" , "christophe.jaillet@wanadoo.fr" , "javier.carrasco@wolfvision.net" , "make_ruc2021@163.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Pawel Eichler , "stable@vger.kernel.org" Subject: Re: [PATCH v3] usb: hub: lack of clearing xHC resources Message-ID: <14c38dde-e2b6-4981-bd24-c714aaa54ef5@rowland.harvard.edu> References: <20250228074307.728010-1-pawell@cadence.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Feb 28, 2025 at 07:50:25AM +0000, Pawel Laszczak wrote: > The xHC resources allocated for USB devices are not released in correct > order after resuming in case when while suspend device was reconnected. > > This issue has been detected during the fallowing scenario: > - connect hub HS to root port > - connect LS/FS device to hub port > - wait for enumeration to finish > - force host to suspend > - reconnect hub attached to root port > - wake host > > For this scenario during enumeration of USB LS/FS device the Cadence xHC > reports completion error code for xHC commands because the xHC resources > used for devices has not been properly released. > XHCI specification doesn't mention that device can be reset in any order > so, we should not treat this issue as Cadence xHC controller bug. > Similar as during disconnecting in this case the device resources should > be cleared starting form the last usb device in tree toward the root hub. > To fix this issue usbcore driver should call hcd->driver->reset_device > for all USB devices connected to hub which was reconnected while > suspending. > > Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver") > cc: > Signed-off-by: Pawel Laszczak > > --- > Changelog: > v3: > - Changed patch title > - Corrected typo > - Moved hub_hc_release_resources above mutex_lock(hcd->address0_mutex) > > v2: > - Replaced disconnection procedure with releasing only the xHC resources Reviewed-by: Alan Stern