From: Johannes Berg <johannes@sipsolutions.net>
To: Vitaliy Shevtsov <v.shevtsov@mt-integration.ru>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org,
syzbot+2e5c1e55b9e5c28a3da7@syzkaller.appspotmail.com
Subject: Re: [PATCH] wifi: nl80211: override all other flags if MONITOR_FLAG_COOK_FRAMES is set
Date: Thu, 30 Jan 2025 13:36:28 +0100 [thread overview]
Message-ID: <14c5edc71a74049c49d51960249b0aefc77208be.camel@sipsolutions.net> (raw)
In-Reply-To: <20250130123432.4534-1-v.shevtsov@mt-integration.ru>
On Thu, 2025-01-30 at 17:34 +0500, Vitaliy Shevtsov wrote:
> It is possible to set both MONITOR_FLAG_COOK_FRAMES and MONITOR_FLAG_ACTIVE
> flags simultaneously on the same monitor interface from the userspace. This
> causes a sub-interface to be created with no IEEE80211_SDATA_IN_DRIVER bit
> set because the monitor interface is in the cooked state and it takes
> precedence over all other states. When the interface is then being deleted
> the kernel calls WARN_ONCE() from check_sdata_in_driver() because of missing
> that bit.
>
> Fix this by overriding all flags if MONITOR_FLAG_COOK_FRAMES is set because
> this flag is incompatible with other monitor flags being set.
>
That seems wrong, reject it instead. Anyway we should probably remove
cooked mode.
johannes
next prev parent reply other threads:[~2025-01-30 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 12:34 Vitaliy Shevtsov
2025-01-30 12:36 ` Johannes Berg [this message]
2025-01-30 19:23 ` [lvc-project] " Fedor Pchelkin
2025-01-30 21:13 ` Johannes Berg
2025-02-03 10:40 ` Jouni Malinen
2025-02-03 10:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14c5edc71a74049c49d51960249b0aefc77208be.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lvc-project@linuxtesting.org \
--cc=syzbot+2e5c1e55b9e5c28a3da7@syzkaller.appspotmail.com \
--cc=v.shevtsov@mt-integration.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®