From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=0/rW=DM=vger.kernel.org=linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,
	SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 13036C4363A
	for <linux-kernel@archiver.kernel.org>; Mon,  5 Oct 2020 18:23:33 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id CC6F220853
	for <linux-kernel@archiver.kernel.org>; Mon,  5 Oct 2020 18:23:32 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727589AbgJESXc (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 5 Oct 2020 14:23:32 -0400
Received: from smtprelay0086.hostedemail.com ([216.40.44.86]:57194 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1725960AbgJESXb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 5 Oct 2020 14:23:31 -0400
Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
        by smtprelay06.hostedemail.com (Postfix) with ESMTP id A95871822384E;
        Mon,  5 Oct 2020 18:23:30 +0000 (UTC)
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-HE-Tag: air50_3900439271c0
X-Filterd-Recvd-Size: 1946
Received: from XPS-9350.home (unknown [47.151.133.149])
        (Authenticated sender: joe@perches.com)
        by omf09.hostedemail.com (Postfix) with ESMTPA;
        Mon,  5 Oct 2020 18:23:29 +0000 (UTC)
Message-ID: <14c9d8808feabe987e7fdac867d21ff88561011a.camel@perches.com>
Subject: Re: [PATCH v2] checkpatch: add new warnings to author signoff
 checks.
From:   Joe Perches <joe@perches.com>
To:     Dwaipayan Ray <dwaipayanray1@gmail.com>
Cc:     linux-kernel-mentees@lists.linuxfoundation.org,
        lukas.bulwahn@gmail.com,
        linux-kernel <linux-kernel@vger.kernel.org>
Date:   Mon, 05 Oct 2020 11:23:28 -0700
In-Reply-To: <20201005173933.171074-1-dwaipayanray1@gmail.com>
References: <20201005173933.171074-1-dwaipayanray1@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2020-10-05 at 23:09 +0530, Dwaipayan Ray wrote:
> The author signed-off-by checks are currently very vague.
> Cases like same name or same address are not handled separately.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> +						if ($address1 =~ /(\S+)\+\S+(\@.*)/) {
> +							$address1 = $1.$2;

More common in this code is "$1" . "$2" not $1.$2

> @@ -6891,9 +6917,29 @@ sub process {
[]
> +			# 4 -> names match, addresses excuding mail extensions (subaddresses) match

excluding

perhaps "subaddress detail" instead of "mail extensions (subaddresses)"

And maybe add "from RFC 5233"

> +
> +			my $sob_msg = "'From: $author' != 'Signed-off-by: $author_sob'";
> +
> +			if ($authorsignoff == 0) {
> +				WARN("NO_AUTHOR_SIGN_OFF",
> +				     "Missing Signed-off-by: line by nominal patch author '$author'\n");
> +			} elsif ($authorsignoff == 2) {
> +				WARN("NO_AUTHOR_SIGN_OFF",
> +				     "From:/Signed-off-by: email name mismatch:\n$sob_msg\n");


Still no need for a newline to separate the output message.