From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011009.outbound.protection.outlook.com [40.93.194.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49AFB26F29F for ; Thu, 27 Nov 2025 10:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.9 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764238360; cv=fail; b=hzro5ssO9Xs1aSslIQ9KEpRIO+c6veWz+Ne5fvH2VzdEm+umwZYEUFNhupAzHI5oWH8yRWWii4zeC9H3UHC6EV7/iHrIQOvWcV/HlLjh5ApaVuKiePOJ+E+W6TBJgj+z90iDdqWpTcmhBk0jKuG0wCf4BiId/tEgR6tkIUjBjLw= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764238360; c=relaxed/simple; bh=E65RFLLJG1+ZjTkNAJPNRgUpPgy3rOcv0qQ9vD4QpVI=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=IThsz1pbrvAHVftr3Q3q3EFenNjEgUL03IzFUhy8PcHkhs+et302ybPku+eUdm8Lpusf6JfHxF8PraFBM9+OYnvn/y+9LLz5xa5Ur8r0IPnrTjK/G4/VI+cXyUMI+Ec5s08KQNaAiKWq3pCCssnjaNXjs+9VO2wKDiOcPDdvx1g= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ED/kHXBR; arc=fail smtp.client-ip=40.93.194.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ED/kHXBR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ReJJYKoCMVWXlULKfW6NPX/PMunANSAS3sfZ/EHptFM78/6VOVEO8p8tJSe+mmZYGXIdXpdD+XDBnkoFqm0wnvMW/WEoh/+8xIx/9W9z6fZZ0dPlxlWb2ND5pab268mt/Uhad8ltcOlTrTZX/2s273F6DnoaOfHWnUpvjAFLDXEcc0N7n99q9BR5AHajd3RnJ3WKylCAlV2Dq1n51GH00uCV/kJQMOZpivQyGlv1apub83S8wAbKOLQxKPkBKTSa0SsCWbs46TyRA1HmLLj/NDI1iNZkehwKLkExDHaDEE3y3sAhIOddXudCPls6tUtyVyzLERY61DKExgw67M9yUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GO6t3vx/B4GkIlOnOEzXTBzSLiwMcumuwVOt6ZzswyI=; b=tCCk6LBJvr4LAyoc7YlYo7hJa3rYBMP7axVErGLO2xMxPRhVmTW1i6PH8lzTkrlYWwKHjhsC63Onl0JXGjHfrR1VoxWzjmbZ+iXquryCX7EXkxKcKCJ+X6WMjBZdsKOF0MpD21NOyaE4ObMKktKBdx/QtYnQoxNXUmTZ+Mu1IO0vDe77KSZlpSFPIHxHg19Lhgu/VH2gF+S+HPY7xBxRuc7tlmeswLCfFA1v3dQda0DKcIXB/rThCi867sE/oqEBHJDmEfGaqCsuzxOs6D5liEyRuuqJwUAk9XAFsVw7e+m21Gy3WGS4EN0Csvl9tqaBu8INpOasp9dq/18NPkAnjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=os.amperecomputing.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GO6t3vx/B4GkIlOnOEzXTBzSLiwMcumuwVOt6ZzswyI=; b=ED/kHXBRUD1djhyFcPPbiIo2pMarOZRMzvCeLkSnwqv6vSEnvt/FQxZP+k5hjfAo1DUVRUXXfAjK7eGcg//rsGItV8dPO0IKw7lkelnn2Wc3/ciFdLfX/nfkEjwUNxixTQjAA5P/5ljawwk+VtsAnq12v5QNBiAbVVHZMYFzGVk= Received: from BY3PR05CA0013.namprd05.prod.outlook.com (2603:10b6:a03:254::18) by MN2PR12MB4110.namprd12.prod.outlook.com (2603:10b6:208:1dd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.14; Thu, 27 Nov 2025 10:12:35 +0000 Received: from BY1PEPF0001AE19.namprd04.prod.outlook.com (2603:10b6:a03:254:cafe::27) by BY3PR05CA0013.outlook.office365.com (2603:10b6:a03:254::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9388.4 via Frontend Transport; Thu, 27 Nov 2025 10:12:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BY1PEPF0001AE19.mail.protection.outlook.com (10.167.242.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9366.7 via Frontend Transport; Thu, 27 Nov 2025 10:12:34 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Thu, 27 Nov 2025 04:12:34 -0600 Received: from satlexmb07.amd.com (10.181.42.216) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 27 Nov 2025 04:12:34 -0600 Received: from [172.31.184.125] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 27 Nov 2025 02:12:29 -0800 Message-ID: <14d4ab40-aa3e-48de-99f5-4f1d799b5f7b@amd.com> Date: Thu, 27 Nov 2025 15:42:24 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] sched: update the rq->avg_idle when a task is moved to an idle CPU To: Huang Shijie , , , , CC: , , , , , , , , , References: <20251127091450.250797-1-shijie@os.amperecomputing.com> <20251127091450.250797-3-shijie@os.amperecomputing.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20251127091450.250797-3-shijie@os.amperecomputing.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Received-SPF: None (SATLEXMB04.amd.com: kprateek.nayak@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY1PEPF0001AE19:EE_|MN2PR12MB4110:EE_ X-MS-Office365-Filtering-Correlation-Id: ea2c6a04-53e7-4f5d-3fe3-08de2d9d7c21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|7416014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?K1oyV3NvUDYra2VuQ240SHRKWFp1dS9GM2tkT0tlaEc5K0JwY00yRHV5MUMz?= =?utf-8?B?K0NCTmh5YzR4d2k2dzlTWXVRRG84ZXVBeDhyR3U5UlBjckh1WGZmZTN6SUJo?= =?utf-8?B?VjF5WG45VXhxc0JZZUJhZmtpbWR0eC9hZVhPc3RacEwxNkU0QjFveGIwY0tr?= =?utf-8?B?QzZ5QW5rWmZzSlBGNkRoWTVua044TGE2MFgvUEwxTjVMc2E2OGFEV2llZFRD?= =?utf-8?B?d3ltZmtWeW9qRFliK3Y1YVJsbUdwVkthaFZUMjB5VFZuZlEwSkVKVGhEWXov?= =?utf-8?B?NkpJWFdlRnZpc01sVjNDZkF6a0pWVWlXUHY5KzhwRWdBTzB5OXUrZ0Z0WEZk?= =?utf-8?B?MUJiUjFVUmN3eXZ0eUFuUEZmY2N2TmdGbGJPSCttdmFLckZFZGE0QmhacXNP?= =?utf-8?B?WGxHSTNsQkowazdnSVN2ZVRrSUhUVjVTcVBEREtLdVJDNlJWNWRvWUNMOUVR?= =?utf-8?B?NGVxM1ZJOVp5Ymk3TGZSY1dtR3pvcmxlUER6bnB3Z3ZmUlhCeVgrYVhBcmJ6?= =?utf-8?B?ZWVyclVLZnZBWWE3S1dzMmNSeXNLSmU2aHNTQnNrcWk1N0l3U1RqS2wwcmVB?= =?utf-8?B?Q3c2bjNWUGltQVdFVDJSRGVtckRXT0JnaHJMeG5ialR2Y2FUUG5oVGNiYTF6?= =?utf-8?B?ZmMrTzBLYkVScWx6c3kxYTJPMWNtWldCWjlQMlhWTWFiS3pNZ0RQTUxrZS9w?= =?utf-8?B?RWZnVndqdUZqNWFIdVNZNW9meldrbjJPdlNjS0tJRGNhUnljeDV6M0dpWEFw?= =?utf-8?B?WEJCcEJ3dG95Q2V2NkxBK25Ra0RnVjVaQk9RN1J1MWFxY2d5c0RaUEYrbU5u?= =?utf-8?B?VEdBYnIyVDdzWWl6NE9zMDM0bE43ZGtWdE1uRTlBT3JhNGVGYnVrSG10STVF?= =?utf-8?B?SGVOSlFpSkhmVUNoWEFzNTFpdlVFbTZWMmRIZ3YySUNMZlB4SkhCLzFNSExO?= =?utf-8?B?cTFzTU5ScStOYkN4MlRoeCtrNUVoQi9VcFJ3cVRLdEo3WlRncC82MWIzRElZ?= =?utf-8?B?d2lvYUVEYzBaOGF2NURqaFdHRzhzTURJb056T0hCUjkybUV4VzhKV2IzMDda?= =?utf-8?B?Y05QQlFLK2FUdG85MkdxYXRKSDB3ajliUFYxSE81MlRVUzVBamoyR3RsRDdE?= =?utf-8?B?YTFmeElvNjhiVms3WUh2a0lNZlJuMzQrZHp5SldWbC9ieG16azkvTzFHdkZq?= =?utf-8?B?WjVTbExPT1RzbTdoOVZPMXk4Y2kxS0hKdFRaQ3VMRmtQMUQ2blNpYUw3eUsy?= =?utf-8?B?ZG5rRS9CVXdMNmwxVFhxbFVWSUkvQktvdm8rWXAveGZ6SmJaTExSbEdKMnpS?= =?utf-8?B?dHc4U3lBZm9EdHc0WENDK0RWbk9ZQlZsMkhhbDRleXgwNDVjVlJDb1BwbC9i?= =?utf-8?B?V0xqSzFNSHMzQkZ3YjUrVWxRSnczS3luN1h3UWZnTFR2c2hmUXRLR1RHcVps?= =?utf-8?B?ZHFlMnlUcXRVTHI1Mzh3aVF2Q3dCcUVVSXhjL1FkSUhiNHU4anZCMXl5Qy9W?= =?utf-8?B?Q1dGcHBCNnN4bHFBVUQ4K2RkQ1dHemtGQ0lxaHRhUFR3RXBhTy82VmZYaDht?= =?utf-8?B?bmhYdUY3WFR6SUpWUXVMZi8wS0NYaE96bW9rdXYreHczWEhYNGYySXdZdmV3?= =?utf-8?B?Q0RTZzQ2UTlOTUZnU2N3YUtSZDE0NnhnV002OGdvQUlTdXB1U0dkNk5qMUxS?= =?utf-8?B?R2tESWpHaUJOZWhrcmZBWnlVUGtxTklOZEhiQlBFdjJJM3hrSXI3TlNoZzdn?= =?utf-8?B?SDZFUG5PN09FVXRMMlV6WEZjQWd3aEtRQmlQRWxzVlpRZGkvYTJabU8rNVdw?= =?utf-8?B?SzV5MStybjd0K2F3V1hBRkRGZEZiVENoZDJ3aXN4QVVZSDdRUGFNTHpxQnRX?= =?utf-8?B?VDFGY1JjdDg2a1Q4UVc2TlUrZVdtYStBRVhSQTF3dUhOaHhNSG9aRXRDcWZt?= =?utf-8?B?ZEZwNHJkRjI0bVRvdlJCcFJnd0g0VDl5YUZwaE1vZFk0N1hqUHFGYjdKNGZk?= =?utf-8?B?Zy9ZcE9iUmVzUFRtZ1dBUUhmemFIWGsxZmd0VXpoMEpqRG1nd2pjTmhpZllH?= =?utf-8?B?WjJIa09XRmd1K2lNU2hYZXJFUmFUZkRNZlNxYTZMY2dsT1lpVmtzOGU2bFlF?= =?utf-8?Q?Z1T0=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(7416014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Nov 2025 10:12:34.7764 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea2c6a04-53e7-4f5d-3fe3-08de2d9d7c21 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BY1PEPF0001AE19.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4110 Hello Huang Shijie, On 11/27/2025 2:44 PM, Huang Shijie wrote: > void enqueue_task(struct rq *rq, struct task_struct *p, int flags) > { > + int delayed = p->se.sched_delayed; > + > if (!(flags & ENQUEUE_NOCLOCK)) > update_rq_clock(rq); > > @@ -2100,6 +2117,13 @@ void enqueue_task(struct rq *rq, struct task_struct *p, int flags) > > if (sched_core_enabled(rq)) > sched_core_enqueue(rq, p); > + > + if (delayed) { > + if (entity_eligible(cfs_rq_of(&p->se), &p->se)) > + update_rq_avg_idle(rq); Question: Why do we want to treat the delayed case like this? If entity is not eligible, we want to consider that it hasn't even gone through a wakeup? Wouldn't this lead to the next wakeup seeing rq->idle_stamp to be non-zero and inaccurately account more idle time? Also if we've done newidle balance and the rq->idle_stamp is set, we cannot have delayed tasks since pick_next_task() would have dequeued all delayed tasks before reaching newidle balance. Just doing a update_rq_avg_idle() unconditionally should be fine. > + } else { > + update_rq_avg_idle(rq); > + } > } > > /* -- Thanks and Regards, Prateek