From: Sudeep Holla <sudeep.holla@arm.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Icenowy Zheng <icenowy@aosc.xyz>,
Russell King <linux@armlinux.org.uk>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Jorik Jonker <jorik@kippendief.biz>,
Hans de Goede <hdegoede@redhat.com>,
Quentin Schulz <quentin.schulz@free-electrons.com>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>
Subject: Re: [PATCH 3/6] ARM: dts: sun8i: add a cpu0 label to cpu@0 node on A23/33
Date: Tue, 13 Dec 2016 16:45:05 +0000 [thread overview]
Message-ID: <14d63396-0e20-3b25-2ff5-1457823b69bf@arm.com> (raw)
In-Reply-To: <CAGb2v65=Sh-WMEVk0Db48sgUcV6d7-wF_Yh0yJAHANMkGUzFwQ@mail.gmail.com>
On 13/12/16 16:31, Chen-Yu Tsai wrote:
> On Wed, Dec 14, 2016 at 12:09 AM, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>>
>> On 13/12/16 15:22, Icenowy Zheng wrote:
>>> A "cpu0" label is needed on cpu@0 for cpufreq-dt to work.
>>>
>>
>> IIUC any label should be fine and I don't see anything in the driver
>> looking for such label name. All I see is it looks for cpu0 regulator
>> for *legacy* DTs
>>
>>> Add such a label, in order to prepare for cpufreq support of A23/33.
>>>
>>
>> You need this as you add the same label in the following patches. The
>> commit message sounds like cpufreq-dt search for that label by name.
>
> I think a more proper explanation would be:
>
> The cpu's supply regulator is specified at the board level, hence we
> need to add a label to it to reference it without replicating the whole
> tree structure.
Thanks for clarifying, was confused based on the commit log.
--
Regards,
Sudeep
next prev parent reply other threads:[~2016-12-13 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161213152252.53749-1-icenowy@aosc.xyz>
[not found] ` <20161213152252.53749-2-icenowy@aosc.xyz>
2016-12-13 15:44 ` [PATCH 1/6] clk: sunxi-ng: fix PLL_CPUX adjusting on A33 Maxime Ripard
[not found] ` <20161213152252.53749-3-icenowy@aosc.xyz>
2016-12-13 15:44 ` [PATCH 2/6] clk: sunxi-ng: set the parent rate when adjustin CPUX clock " Maxime Ripard
[not found] ` <306991481662454@web33j.yandex.ru>
2016-12-14 9:21 ` Maxime Ripard
[not found] ` <20161213152252.53749-4-icenowy@aosc.xyz>
2016-12-13 15:45 ` [PATCH 3/6] ARM: dts: sun8i: add a cpu0 label to cpu@0 node on A23/33 Maxime Ripard
2016-12-13 16:09 ` Sudeep Holla
2016-12-13 16:31 ` Chen-Yu Tsai
2016-12-13 16:45 ` Sudeep Holla [this message]
[not found] ` <20161213152252.53749-5-icenowy@aosc.xyz>
2016-12-13 19:12 ` [PATCH 4/6] ARM: dts: sun8i: add opp-v2 table for A33 Maxime Ripard
[not found] ` <20161213152252.53749-6-icenowy@aosc.xyz>
2016-12-13 19:13 ` [PATCH 5/6] ARM: dts: sun8i: set cpu-supply in reference tablet DTSI Maxime Ripard
[not found] ` <20161213152252.53749-7-icenowy@aosc.xyz>
2016-12-13 19:14 ` [PATCH 6/6] ARM: dts: sun8i: raise the max voltage of DCDC2 in sun8i reference tablets Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14d63396-0e20-3b25-2ff5-1457823b69bf@arm.com \
--to=sudeep.holla@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.xyz \
--cc=jorik@kippendief.biz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.ripard@free-electrons.com \
--cc=mturquette@baylibre.com \
--cc=quentin.schulz@free-electrons.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®