From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: David Stevens <stevensd@chromium.org>,
Sean Christopherson <seanjc@google.com>
Cc: Yu Zhang <yu.c.zhang@linux.intel.com>,
Isaku Yamahata <isaku.yamahata@gmail.com>,
Zhi Wang <zhi.wang.linux@gmail.com>,
kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v9 6/6] KVM: x86/mmu: Handle non-refcounted pages
Date: Mon, 18 Sep 2023 12:58:32 +0300 [thread overview]
Message-ID: <14db8c0b-77de-34ec-c847-d7360025a571@collabora.com> (raw)
In-Reply-To: <20230911021637.1941096-7-stevensd@google.com>
On 9/11/23 05:16, David Stevens wrote:
> From: David Stevens <stevensd@chromium.org>
>
> Handle non-refcounted pages in __kvm_faultin_pfn. This allows the host
> to map memory into the guest that is backed by non-refcounted struct
> pages - for example, the tail pages of higher order non-compound pages
> allocated by the amdgpu driver via ttm_pool_alloc_page.
>
> The bulk of this change is tracking the is_refcounted_page flag so that
> non-refcounted pages don't trigger page_count() == 0 warnings. This is
> done by storing the flag in an unused bit in the sptes. There are no
> bits available in PAE SPTEs, so non-refcounted pages can only be handled
> on TDP and x86-64.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> arch/x86/kvm/mmu/mmu.c | 52 +++++++++++++++++++++++----------
> arch/x86/kvm/mmu/mmu_internal.h | 1 +
> arch/x86/kvm/mmu/paging_tmpl.h | 8 +++--
> arch/x86/kvm/mmu/spte.c | 4 ++-
> arch/x86/kvm/mmu/spte.h | 12 +++++++-
> arch/x86/kvm/mmu/tdp_mmu.c | 22 ++++++++------
> include/linux/kvm_host.h | 3 ++
> virt/kvm/kvm_main.c | 6 ++--
> 8 files changed, 76 insertions(+), 32 deletions(-)
Could you please tell which kernel tree you used for the base of this
series? This patch #6 doesn't apply cleanly to stable/mainline/next/kvm
error: sha1 information is lacking or useless (arch/x86/kvm/mmu/mmu.c).
error: could not build fake ancestor
--
Best regards,
Dmitry
next prev parent reply other threads:[~2023-09-18 9:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 2:16 [PATCH v9 0/6] KVM: allow mapping " David Stevens
2023-09-11 2:16 ` [PATCH v9 1/6] KVM: Assert that a page's refcount is elevated when marking accessed/dirty David Stevens
2023-09-11 2:16 ` [PATCH v9 2/6] KVM: mmu: Introduce __kvm_follow_pfn function David Stevens
2023-10-03 16:54 ` Maxim Levitsky
2024-02-06 1:25 ` Sean Christopherson
2024-02-06 3:16 ` Sean Christopherson
2024-02-13 3:27 ` Sean Christopherson
2024-02-13 3:44 ` Sean Christopherson
2023-09-11 2:16 ` [PATCH v9 3/6] KVM: mmu: Improve handling of non-refcounted pfns David Stevens
2023-10-03 16:54 ` Maxim Levitsky
2024-02-06 2:54 ` Sean Christopherson
2024-02-13 3:44 ` Sean Christopherson
2023-09-11 2:16 ` [PATCH v9 4/6] KVM: Migrate kvm_vcpu_map to __kvm_follow_pfn David Stevens
2023-10-03 16:54 ` Maxim Levitsky
2023-09-11 2:16 ` [PATCH v9 5/6] KVM: x86: Migrate " David Stevens
2023-10-03 16:54 ` Maxim Levitsky
2023-10-03 20:58 ` Sean Christopherson
2023-09-11 2:16 ` [PATCH v9 6/6] KVM: x86/mmu: Handle non-refcounted pages David Stevens
2023-09-18 9:53 ` Dmitry Osipenko
2023-09-19 2:25 ` David Stevens
2023-09-30 13:34 ` Dmitry Osipenko
2023-09-18 9:58 ` Dmitry Osipenko [this message]
2023-09-18 11:19 ` Dmitry Osipenko
2023-09-19 2:59 ` David Stevens
2023-09-21 20:06 ` Dmitry Osipenko
2023-09-30 13:34 ` Dmitry Osipenko
2023-09-19 2:31 ` David Stevens
2023-09-21 20:04 ` Dmitry Osipenko
2024-02-06 3:02 ` Sean Christopherson
2023-10-03 16:54 ` Maxim Levitsky
2024-02-06 3:23 ` Sean Christopherson
2023-09-29 5:19 ` [PATCH v9 0/6] KVM: allow mapping " Christoph Hellwig
2023-09-29 16:06 ` Sean Christopherson
2023-10-02 6:25 ` Christoph Hellwig
2024-02-06 3:29 ` Sean Christopherson
2023-10-31 4:30 ` David Stevens
2023-10-31 14:30 ` Sean Christopherson
2023-12-12 1:59 ` David Stevens
2023-12-20 1:37 ` Sean Christopherson
2024-02-06 3:30 ` Sean Christopherson
2024-02-13 3:39 ` Sean Christopherson
2024-02-21 6:05 ` David Stevens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14db8c0b-77de-34ec-c847-d7360025a571@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=isaku.yamahata@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=stevensd@chromium.org \
--cc=yu.c.zhang@linux.intel.com \
--cc=zhi.wang.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®