From: Dinh Nguyen <dinguyen@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Olof Johansson <olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] reset: socfpga: declare socfpga_reset_init in a header file
Date: Thu, 13 Dec 2018 11:17:44 -0600 [thread overview]
Message-ID: <14dd69f9-c281-efdc-eaa9-bbf879d200a6@kernel.org> (raw)
In-Reply-To: <20181213123358.24391-3-p.zabel@pengutronix.de>
On 12/13/18 6:33 AM, Philipp Zabel wrote:
> Avoid declaring extern functions in c files. To make sure function
> definition and usage don't get out of sync, declare socfpga_reset_init
> in a common header.
>
> Suggested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
prev parent reply other threads:[~2018-12-13 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 12:33 [PATCH 0/2] reset: socfpga, sunxi: declare _reset_init functions in header files Philipp Zabel
2018-12-13 12:33 ` [PATCH 1/2] reset: sunxi: declare sun6i_reset_init in a header file Philipp Zabel
2018-12-13 12:33 ` [PATCH 2/2] reset: socfpga: declare socfpga_reset_init " Philipp Zabel
2018-12-13 17:17 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14dd69f9-c281-efdc-eaa9-bbf879d200a6@kernel.org \
--to=dinguyen@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=sfr@canb.auug.org.au \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®