mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
	"xianfengting221@163.com" <xianfengting221@163.com>,
	"leon@kernel.org" <leon@kernel.org>
Cc: "cai@lca.pw" <cai@lca.pw>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"lsahlber@redhat.com" <lsahlber@redhat.com>,
	"kw@linux.com" <kw@linux.com>,
	"xiubli@redhat.com" <xiubli@redhat.com>,
	"airlied@redhat.com" <airlied@redhat.com>,
	Moshe Shemesh <moshe@mellanox.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"wqu@suse.com" <wqu@suse.com>,
	"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
	"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
	"stfrench@microsoft.com" <stfrench@microsoft.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] net/mlx5: add the missing space character
Date: Wed, 8 Apr 2020 19:42:49 +0000	[thread overview]
Message-ID: <14df0ecf093bb2df4efaf9e6f5220ea2bf863f53.camel@mellanox.com> (raw)
In-Reply-To: <20200403042659.9167-1-xianfengting221@163.com>

On Fri, 2020-04-03 at 12:26 +0800, Hu Haowen wrote:
> Commit 91b56d8462a9 ("net/mlx5: improve some comments") did not add
> that missing space character and this commit is used to fix it up.
> 
> Fixes: 91b56d8462a9 ("net/mlx5: improve some comments")
> 

Please re-spin and submit to net-next once net-next re-opens, 
avoid referencing the above commit since this patch is a stand alone
and has nothing to do with that patch.. just have a stand alone commit
message explaining the space fix.

i fixed the commit message of the previous patch, so the Fixes tag is
unnecessary 

> Signed-off-by: Hu Haowen <xianfengting221@163.com>


> ---
>  drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> index c9c9b479bda5..31bddb48e5c3 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
> @@ -676,7 +676,7 @@ static void mlx5_fw_tracer_handle_traces(struct
> work_struct *work)
>  	block_count = tracer->buff.size / TRACER_BLOCK_SIZE_BYTE;
>  	start_offset = tracer->buff.consumer_index *
> TRACER_BLOCK_SIZE_BYTE;
>  
> -	/* Copy the block to local buffer to avoid HW override while
> being processed*/
> +	/* Copy the block to local buffer to avoid HW override while
> being processed */
>  	memcpy(tmp_trace_block, tracer->buff.log_buf + start_offset,
>  	       TRACER_BLOCK_SIZE_BYTE);
>  

  reply	other threads:[~2020-04-08 19:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-03  4:26 Hu Haowen
2020-04-08 19:42 ` Saeed Mahameed [this message]
2020-04-16 14:44   ` Hu Haowen
2020-04-17  3:44     ` Saeed Mahameed
2020-04-17  4:34       ` Hu Haowen
2020-04-17 22:40         ` Saeed Mahameed
2020-04-18 12:54           ` Hu Haowen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14df0ecf093bb2df4efaf9e6f5220ea2bf863f53.camel@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=airlied@redhat.com \
    --cc=cai@lca.pw \
    --cc=chris@chris-wilson.co.uk \
    --cc=davem@davemloft.net \
    --cc=kw@linux.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lsahlber@redhat.com \
    --cc=moshe@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=stfrench@microsoft.com \
    --cc=wqu@suse.com \
    --cc=xianfengting221@163.com \
    --cc=xiubli@redhat.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®