From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE176CA0EC3 for ; Mon, 11 Sep 2023 21:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349243AbjIKVcz (ORCPT ); Mon, 11 Sep 2023 17:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236603AbjIKLDe (ORCPT ); Mon, 11 Sep 2023 07:03:34 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26B4DCC3; Mon, 11 Sep 2023 04:03:30 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id BFB6066072FC; Mon, 11 Sep 2023 12:03:27 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1694430208; bh=toQiYutVle+i27Bqgs6ZEGNKjIE11r2s6PXTNuIUBLU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=BOsOOsKe7nx8QyxFFqapO85pc3cpScbG26NcaLQ+4pM/bVHwXKA3N8HzuoVKPCbd+ qVz7WdDbO+JRhSvqM8QYxZccZffeHPIDSe08gnLdvpzVmBzl2CN/DeIKZeeZGX3MNX FN6ZoqqBva5HC8zvidePc1HKeaSU7w8Eip7Cv+ojCZq6x9UHyRvO2j+/oiZWNXJ4XM 1VRLeuPL5fh3EcEgVN2S5CVWiIY4e8+mHRm3D0nzhxgZ1RkB0+3vQtzyRZaoD5lAxN XLgQsqhVgu2BHVAXJy2yjrwmlrzz6Iql/i18Q0596zJjA6hhXfebejW3hIeBteMnL2 1LsZ/nmyWfFFg== Message-ID: <14e03873-3723-8293-0190-445a71828b25@collabora.com> Date: Mon, 11 Sep 2023 13:03:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v3,2/3] drm/mediatek: dsi: Add dsi cmdq_ctl to send panel initial code Content-Language: en-US To: Shuijing Li , chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, matthias.bgg@gmail.com, jitao.shi@mediatek.com Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230911105736.11752-1-shuijing.li@mediatek.com> <20230911105736.11752-3-shuijing.li@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230911105736.11752-3-shuijing.li@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 11/09/23 12:57, Shuijing Li ha scritto: > For mt8188, add dsi cmdq reg control to send long packets to panel > initialization. MT8188 hardware has been changed to automatically > set the cmdq_size value by default when sending long packets. > In this patch, the cmdq_size value is set manually instead. > Remain consistent with previous IC. > > Signed-off-by: Shuijing Li > --- > Changes in v3: > reorder patch 2/3 and 3/3, and describe more about why mt8188 need this > patch, > per suggestion from the previous thread: > https://lore.kernel.org/lkml/411ddbf95e2c2298b84899065691d478069ec273.camel@mediatek.com/ > Changes in v2: > use mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL); directly, > per suggestion from the previous thread: > https://lore.kernel.org/lkml/015f4c60-ed77-9e1f-8a6b-cda6e4f6ac93@gmail.com/ > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index d8bfc2cce54d..e83705394ada 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -86,6 +86,7 @@ > > #define DSI_CMDQ_SIZE 0x60 > #define CMDQ_SIZE 0x3f > +#define CMDQ_SIZE_SEL BIT(15) > > #define DSI_HSTX_CKL_WC 0x64 > > @@ -178,6 +179,7 @@ struct mtk_dsi_driver_data { > const u32 reg_cmdq_off; > bool has_shadow_ctl; > bool has_size_ctl; > + bool cmdq_long_packet_ctl; > }; > > struct mtk_dsi { > @@ -996,6 +998,8 @@ static void mtk_dsi_cmdq(struct mtk_dsi *dsi, const struct mipi_dsi_msg *msg) > > mtk_dsi_mask(dsi, reg_cmdq_off, cmdq_mask, reg_val); > mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE, cmdq_size); > + if (dsi->driver_data->cmdq_long_packet_ctl) Please add a comment here, like: /* Disable setting cmdq_size automatically for long packets */ after which Reviewed-by: AngeloGioacchino Del Regno > + mtk_dsi_mask(dsi, DSI_CMDQ_SIZE, CMDQ_SIZE_SEL, CMDQ_SIZE_SEL); > } > > static ssize_t mtk_dsi_host_send_cmd(struct mtk_dsi *dsi,