From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E29A7C43334 for ; Thu, 21 Jul 2022 13:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229697AbiGUNfW (ORCPT ); Thu, 21 Jul 2022 09:35:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbiGUNfU (ORCPT ); Thu, 21 Jul 2022 09:35:20 -0400 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7561DEA7 for ; Thu, 21 Jul 2022 06:35:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8YFbTHxQthzOWNFDNujZ6xnF8BTNw3UEG0+j6FNXCWU=; b=snffF4nd3H4L5E8gMhriYYOREh Q71a9ezaDjUGUnhsZtzY8/6EqCqPZAZsLJWRRmW7bzR5EDMe31n5bfVa3A1mAYMihCLdi3uzzSvoT gDwXOgQkCwpnWcPbfySE+BwUB1JiP4NsH1DwT+Y0bS4ofjHH4Pjt8av2BZdtp8OzwOzdnHQy4Irkk HezfoOlKUFq7nOib9NARIY0vbDtnb/opPPQ68oZ4mdh3M5Du4xmxfyQ0uhMdZ9aqlBZXy7gGq8G32 bB8tHDbluUYKSYw4HdZ1tfnvSiTr+uFH+1fM+5+Cpp9aA+MlL17DzfbllssIbqpxhgJy8IEgOmet8 sAxzouGA==; Received: from 201-13-50-220.dsl.telesp.net.br ([201.13.50.220] helo=[192.168.15.109]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1oEWKh-001UuF-57; Thu, 21 Jul 2022 15:35:15 +0200 Message-ID: <14e11a4b-7300-a54d-6794-1eeb7ab8a079@igalia.com> Date: Thu, 21 Jul 2022 10:34:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/4] drm/amd/display: Remove duplicated CalculateWriteBackDISPCLK Content-Language: en-US To: =?UTF-8?Q?Ma=c3=adra_Canal?= Cc: magalilemes00@gmail.com, christian.koenig@amd.com, Daniel Vetter , Xinhui.Pan@amd.com, Alex Deucher , Rodrigo Siqueira , Leo Li , Nicholas Kazlauskas , tales.aparecida@gmail.com, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, mwen@igalia.com, Aurabindo Pillai , Dmytro Laktyushkin , Isabella Basso , andrealmeid@riseup.net, Harry Wentland , David Airlie References: <20220720182228.259119-1-mairacanal@riseup.net> <20220720182228.259119-2-mairacanal@riseup.net> From: =?UTF-8?Q?Andr=c3=a9_Almeida?= In-Reply-To: <20220720182228.259119-2-mairacanal@riseup.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Às 15:22 de 20/07/22, Maíra Canal escreveu: > The functions dml30_CalculateWriteBackDISPCLK and > dml31_CalculateWriteBackDISPCLK are identical. Therefor, to avoid > code duplication, dml31_CalculateWriteBackDISPCLK is removed and > replaced by dml30_CalculateWriteBackDISPCLK. > The message should be in imperative mood: "to avoid code duplication, dml31_CalculateWriteBackDISPCLK is removed and replaced by dml30_CalculateWriteBackDISPCLK." -> "to avoid code duplication, replace dml31_CalculateWriteBackDISPCLK by dml30_CalculateWriteBackDISPCLK" > Signed-off-by: Maíra Canal > ---