From: Michael Straube <straube.linux@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c
Date: Wed, 5 Sep 2018 13:44:43 +0200 [thread overview]
Message-ID: <14e81d5c-cafd-4d6d-13a7-87f7d97a5ae3@gmail.com> (raw)
In-Reply-To: <20180905081315.bdbotkyfpdkdj537@mwanda>
On 9/5/18 10:13 AM, Dan Carpenter wrote:
> On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote:
>>
>> case LED_CTL_SITE_SURVEY:
>> - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && (check_fwstate(pmlmepriv, _FW_LINKED))) {
>> - ;
>> - } else if (!pLed->bLedScanBlinkInProgress) {
>> + if (!pLed->bLedScanBlinkInProgress) {
>
> I think you have introduced a bug...
Ah yes I see now, thanks.
Would it be ok to merge the conditions in a single if?
if ((!pmlmepriv->LinkDetectInfo.bBusyTraffic ||
!check_fwstate(pmlmepriv, _FW_LINKED)) &&
!pLed->bLedScanBlinkInProgress) {
regards,
Michael
next prev parent reply other threads:[~2018-09-05 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 11:16 Michael Straube
2018-09-04 11:16 ` [PATCH 2/2] staging: rtl8188eu: remove unnecessary parentheses " Michael Straube
2018-09-05 8:13 ` [PATCH 1/2] staging: rtl8188eu: remove empty if statement " Dan Carpenter
2018-09-05 11:44 ` Michael Straube [this message]
2018-09-05 12:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14e81d5c-cafd-4d6d-13a7-87f7d97a5ae3@gmail.com \
--to=straube.linux@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome