From: Guenter Roeck <linux@roeck-us.net>
To: "Rob Herring (Arm)" <robh@kernel.org>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Marek Behún" <kabel@kernel.org>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: watchdog: Convert marvell,armada-3700-wdt to DT schema
Date: Tue, 12 Aug 2025 14:11:55 -0700 [thread overview]
Message-ID: <14ed9b3b-92a7-453f-a585-858e9f2ea37a@roeck-us.net> (raw)
In-Reply-To: <20250812203301.726374-1-robh@kernel.org>
On 8/12/25 13:32, Rob Herring (Arm) wrote:
> Convert the Marvell Armada 3700 watchdog binding to DT schema format.
> It's a straight-forward conversion.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> .../bindings/watchdog/armada-37xx-wdt.txt | 23 -----------
> .../watchdog/marvell,armada-3700-wdt.yaml | 41 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 42 insertions(+), 24 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/armada-37xx-wdt.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/marvell,armada-3700-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/armada-37xx-wdt.txt b/Documentation/devicetree/bindings/watchdog/armada-37xx-wdt.txt
> deleted file mode 100644
> index a8d00c31a1d8..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/armada-37xx-wdt.txt
> +++ /dev/null
> @@ -1,23 +0,0 @@
> -* Armada 37xx CPU Watchdog Timer Controller
> -
> -Required properties:
> -- compatible : must be "marvell,armada-3700-wdt"
> -- reg : base physical address of the controller and length of memory mapped
> - region.
> -- clocks : the clock feeding the watchdog timer. See clock-bindings.txt
> -- marvell,system-controller : reference to syscon node for the CPU Miscellaneous
> - Registers
> -
> -Example:
> -
> - cpu_misc: system-controller@d000 {
> - compatible = "marvell,armada-3700-cpu-misc", "syscon";
> - reg = <0xd000 0x1000>;
> - };
> -
> - wdt: watchdog@8300 {
> - compatible = "marvell,armada-3700-wdt";
> - reg = <0x8300 0x40>;
> - marvell,system-controller = <&cpu_misc>;
> - clocks = <&xtalclk>;
> - };
> diff --git a/Documentation/devicetree/bindings/watchdog/marvell,armada-3700-wdt.yaml b/Documentation/devicetree/bindings/watchdog/marvell,armada-3700-wdt.yaml
> new file mode 100644
> index 000000000000..60d44d642fb5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/marvell,armada-3700-wdt.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/marvell,armada-3700-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Armada 37xx CPU Watchdog Timer Controller
> +
> +maintainers:
> + - Marek Behún <kabel@kernel.org>
> +
> +properties:
> + compatible:
> + const: marvell,armada-3700-wdt
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + marvell,system-controller:
> + description: Reference to syscon node for the CPU Miscellaneous Registers
> + $ref: /schemas/types.yaml#/definitions/phandle
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - marvell,system-controller
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + watchdog@8300 {
> + compatible = "marvell,armada-3700-wdt";
> + reg = <0x8300 0x40>;
> + marvell,system-controller = <&cpu_misc>;
> + clocks = <&xtalclk>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 06a4cde222bd..6a2de9638c08 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2623,7 +2623,7 @@ F: Documentation/devicetree/bindings/firmware/cznic,turris-mox-rwtm.txt
> F: Documentation/devicetree/bindings/firmware/cznic,turris-omnia-mcu.yaml
> F: Documentation/devicetree/bindings/interrupt-controller/marvell,mpic.yaml
> F: Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml
> -F: Documentation/devicetree/bindings/watchdog/armada-37xx-wdt.txt
> +F: Documentation/devicetree/bindings/watchdog/marvell,armada-3700-wdt.yaml
> F: drivers/bus/moxtet.c
> F: drivers/firmware/turris-mox-rwtm.c
> F: drivers/gpio/gpio-moxtet.c
next prev parent reply other threads:[~2025-08-12 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 20:32 Rob Herring (Arm)
2025-08-12 21:11 ` Guenter Roeck [this message]
2025-09-10 20:55 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14ed9b3b-92a7-453f-a585-858e9f2ea37a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kabel@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®