From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 305532D77E7; Mon, 21 Jul 2025 13:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753103095; cv=none; b=hf7IxRwqqoy9vzbZz53BrwWf51PxKvFa+NxlFvrFz0ZvT67jO/fiJcFC5zD2qt/0nT9GQUV6+nSWfQBic53+xUE36SJCGbaloken2PQ38riesuPNsQRl74FDVo8zj3PBJEj1o5maqYeDfV2M6mtXElZI66LvYKdKRUlu5brn0Uw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753103095; c=relaxed/simple; bh=lTEh95RpPckhSDcCuGDs75biDi8vj53jbp0ovaUO/IQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nv7lFRnPFJh94OTXEBv5ESxxBcJmCmM2B6PGYnDflbVGavJ1j8i2L9H/v54tHzftz2g/6eFLkd/ntGuQGfUg72wD/bpMR87txYZL7qxyAUB+TTKbl+L913ppGRearWDYg+IX4X71ZRWIZb3HafksMaT4Ti4Q6CjNFIAj8bNoE4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KtoWkbN5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KtoWkbN5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA570C4CEED; Mon, 21 Jul 2025 13:04:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753103095; bh=lTEh95RpPckhSDcCuGDs75biDi8vj53jbp0ovaUO/IQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=KtoWkbN5nWyERZwRkXCVPFgzR2BwITsv+FVSpATKu06WNahZJItEB4cQfAo4JNqnH dbSw8YkWDkql34vt2sAj4YGEj5mmrweb5iM//9I5MP215f2jGMGtA6AvcxfgSxwObR P0ZuawTbagnnTd9lDgAVbWrFEJLNk7H/0zwZ8oOfTif8dq7mfIM6d6DGBomQqt2CK1 wVtl0zR/u3UTjQpBrNAJxkK4z5sr8i7oA5gmViqlN2yL6WZYAUZ7fplRIXgmdwc9PN XCJHcHPGEx+5+eeve9/FlzhKz0eAzv13Tl6enelD+aPoFNO1roq5hzG23UX/ZB8rik GbmxhghuNu16Q== Message-ID: <14fc39f9-39dd-4ac6-ad44-349bbe4e5427@kernel.org> Date: Mon, 21 Jul 2025 15:04:50 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] ASoC: dt-bindings: Add FS2104/5S audio amplifiers To: Nick Li Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com, xiaoming.yang@foursemi.com, danyang.zheng@foursemi.com, like.xy@foxmail.com, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250721103805.531758-1-nick.li@foursemi.com> <20250721103805.531758-3-nick.li@foursemi.com> <83f7c489-7001-49cd-97a5-4280eba95fe0@kernel.org> <0D06FAB8CF1A9D4C+aH41IrERxjlsEAPr@foursemi.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <0D06FAB8CF1A9D4C+aH41IrERxjlsEAPr@foursemi.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/07/2025 14:40, Nick Li wrote: > On Mon, Jul 21, 2025 at 02:15:38PM +0200, Krzysztof Kozlowski wrote: >> On 21/07/2025 14:02, Nick Li wrote: >>> On Mon, Jul 21, 2025 at 12:48:24PM +0200, Krzysztof Kozlowski wrote: >>>> On 21/07/2025 12:38, Nick wrote: >>>>> + firmware-name: >>>>> + maxItems: 1 >>>>> + description: | >>>>> + The firmware(*.bin) contains: >>>>> + a. Register initialization settings >>>>> + b. DSP effect parameters >>>>> + c. Multi-scene sound effect configurations(optional) >>>>> + It's gernerated by FourSemi's tuning tool. >>>>> + >>>>> +required: >>>>> + - compatible >>>>> + - reg >>>>> + - '#sound-dai-cells' >>>>> + - reset-gpios >>>>> + - firmware-name >>>> >>>> >>>> I do not see how you resolved my comment from v1 or v2. Nothing in the >>>> changelog explains that either. >>> >>> Change logs are in the cover letter: >> >> >> And as I said I do not see resolution of my comment. >> >> If you reject reviewers comment, usually it should be mentioned in the >> changelog. >> >> Otherwise you get now the same review as v1 or v2. Devices cannot work >> without power. > > I explained it in the previous email: > The power may be connected to the baterry/adapter directly, > it may not be under the control of the software, > in this case, the supplies are use as dummy regulators? You describe here this device, not the board. Does this device needs this to be connected to source of power? Battery is such source. > > And we tested the driver without the supplies in DTS, That's a terrible argument. If I do random changes in my bootloader like toggle on clocks, does that mean that hardware does not need that thing (like clocks)? > so I didn't mark the supplies as the required items. Changelog also did not say you did not implement the comment. Best regards, Krzysztof