mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: isdn@linux-pingi.de, davem@davemloft.net, dhowells@redhat.com,
	johannes.berg@intel.com, mac@melware.de, baoyou.xie@linaro.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 01/10] isdn: hisax: constify pci_device_id.
Date: Sat, 15 Jul 2017 09:55:42 +0530	[thread overview]
Message-ID: <1500092751-8291-2-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500092751-8291-1-git-send-email-arvind.yadav.cs@gmail.com>

pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
  13686	   2064	   4416	  20166	   4ec6	drivers/isdn/hisax/config.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
  15030	    720	   4416	  20166	   4ec6	drivers/isdn/hisax/config.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/isdn/hisax/config.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
index c7d6867..7108bdb8 100644
--- a/drivers/isdn/hisax/config.c
+++ b/drivers/isdn/hisax/config.c
@@ -1909,7 +1909,7 @@ static void EChannel_proc_rcv(struct hisax_d_if *d_if)
 #ifdef CONFIG_PCI
 #include <linux/pci.h>
 
-static struct pci_device_id hisax_pci_tbl[] __used = {
+static const struct pci_device_id hisax_pci_tbl[] __used = {
 #ifdef CONFIG_HISAX_FRITZPCI
 	{PCI_VDEVICE(AVM,      PCI_DEVICE_ID_AVM_A1)			},
 #endif
-- 
2.7.4

  reply	other threads:[~2017-07-15  4:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-15  4:25 [PATCH 00/10] Constify isdn pci_device_id's Arvind Yadav
2017-07-15  4:25 ` Arvind Yadav [this message]
2017-07-15  4:25 ` [PATCH 02/10] isdn: hisax: hfc4s8s_l1: constify pci_device_id Arvind Yadav
2017-07-15  4:25 ` [PATCH 03/10] isdn: hisax: hisax_fcpcipnp: " Arvind Yadav
2017-07-15  4:25 ` [PATCH 04/10] isdn: eicon: " Arvind Yadav
2017-07-15  4:25 ` [PATCH 05/10] isdn: mISDN: netjet: " Arvind Yadav
2017-07-15  4:25 ` [PATCH 06/10] isdn: mISDN: hfcmulti: " Arvind Yadav
2017-07-15  4:25 ` [PATCH 07/10] isdn: mISDN: w6692: " Arvind Yadav
2017-07-15  4:25 ` [PATCH 08/10] isdn: mISDN: avmfritz: " Arvind Yadav
2017-07-15  4:25 ` [PATCH 09/10] isdn: mISDN: hfcpci: " Arvind Yadav
2017-07-15  4:25 ` [PATCH 10/10] isdn: avm: c4: " Arvind Yadav
2017-07-16  4:26 ` [PATCH 00/10] Constify isdn pci_device_id's David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500092751-8291-2-git-send-email-arvind.yadav.cs@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=baoyou.xie@linaro.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=isdn@linux-pingi.de \
    --cc=johannes.berg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mac@melware.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®