From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751253AbdGOGak convert rfc822-to-8bit (ORCPT ); Sat, 15 Jul 2017 02:30:40 -0400 Received: from mout.gmx.net ([212.227.17.21]:54417 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbdGOGai (ORCPT ); Sat, 15 Jul 2017 02:30:38 -0400 Message-ID: <1500100197.27838.21.camel@gmx.de> Subject: Re: [PATCH] debug: fix WARN_ON_ONCE() for modules From: Mike Galbraith To: Josh Poimboeuf , x86@kernel.org Cc: linux-kernel@vger.kernel.org, Peter Zijlstra Date: Sat, 15 Jul 2017 08:29:57 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K0:dI0S8QSQzY6ZDSeE3vQCG2PkxoVCM33UO7t/Zxjg8LxSeG4kj3e ZoDAHfgc9jVMYe2B3nIoBRzncEd43bOS/Owt6nxITf8S+9uG1wi6VuSoWAMKTT+njMAwkpw W6bmE0YBGoPp2CxLoFbVkrC5J31I7LJQfQEV7gLTQNeX5WwCrho1MOlc9FKltWbimo0igXz Sf1x/RVQcc5evOpYAOykA== X-UI-Out-Filterresults: notjunk:1;V01:K0:6Kc6OVxIL9Q=:jBwitZ5CQAt6FDDemD/ZGa z684drZk45wAcNt7zIidd3DY95nhtGgscOvN995aYo2kyBdPQYmHPJelVnNoOA+8akuKOwdp1 EcugkLDQ7NFZkn2Xgnx44Ibxgg2bcamhxkcJdfFf+fNdiZCPcSmc4jjaJwo30YZS6eBVWJtuZ 7ZVPrIeK1nwHK7fGwCN7jJrX44kMjaK2dakzgKSwKtDSWj+f7fKg3DhtJH0DRPIEmE4TJenPh rAkNoFm51uHrXNjULcQg7tUgI/X0NTXDL6RGyIr7T57nzL1nz7lanQDSvbmTm21UzDWH0rWG0 20lu5JgBq+3wKX0iYN7MeoPAoObpyj9qsLUp5qKChkemhujMzN7dL9fR9mzkjsgXrUVcIjbjj 5QW07WabwFPoBGR9tIYI0yJ5WVkFd+3vYOnId2oPllgCHkzMRKkhPefuNxto+CpmliSWKkljg UL9LwnnXLFKcq3Q3J/LRa1ld6Cy7i32Kz5vuLpPw6EwDsmxCCtX0gNskEf0LyCye5FBdBPElT ygYiHBQaKbGUPrA/HFfTWBqlTtDuMnH9X33SXFDkbCr03LV1NR/b8LetTwu9XYzp4Q527PEKn xHotEdGJVX4CyY2zuw4uUEAGAQ5orkZSKIyMvkZM7XKGgsYIZtcZL7oIrl0c1g1HBltLbRRpd CAcmKAzlkNmWsSHFu6vQCDy8KqdhQUbN5SmXbKguPipi30e/jwIxvDNnUykF+GVwAz3QXp4sA o5FfL6DaAXJyXLhcf/v8Zf/8IovATrfb2BTTA7JHE90PvH7qhkxYaDvUS+sV0QXCnAyYZb9X4 WrZvEb2ZsgQjc1kBNIK0+W90JlHoHuRoT2p7nkvcbUvPZG6x8o= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-07-15 at 00:10 -0500, Josh Poimboeuf wrote: > > The bug table was made writable for vmlinux, which relies on > vmlinux.lds.S and vmlinux.lds.h for laying out the sections. However, > it wasn't made writable for modules, which rely on the ELF section > header flags. It seems vmlinux sort of relies on your fix too.  objdump did show vmlinux __bug_table as being READONLY, but that (lie) is now gone. -Mike