From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932910AbcBCUhc (ORCPT ); Wed, 3 Feb 2016 15:37:32 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:55605 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752677AbcBCUh3 (ORCPT ); Wed, 3 Feb 2016 15:37:29 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Sam Ravnborg , linux-arch@vger.kernel.org, Jan Kara , Dan Williams , linux-kernel@vger.kernel.org, "David S. Miller" , linux-mm@kvack.org, Russell King , Matthew Wilcox , Andrew Morton , Ross Zwisler , "Kirill A. Shutemov" Subject: Re: [PATCH] [RFC] ARM: modify pgd_t definition for TRANSPARENT_HUGEPAGE_PUD Date: Wed, 03 Feb 2016 21:36:38 +0100 Message-ID: <15001627.5KATBhJaXU@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160203163946.GA20360@ravnborg.org> References: <1773775.QWf7OyDGPh@wuerfel> <20160203163946.GA20360@ravnborg.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:sc8qCJa52hvGWrBU5tbS9aPBIZBFW4MiFg9mQMVB+F7aS/qdzpK q7kw0bPJioS5QP68OtHGGyCjkJwF+RpWbnRLKMy7dB3EgG7d1y3YWZ2UnTxTpiuXx/Z6wV4 H5eVOxVE39UKp9dXb7P+h6zkYu3My/46gi0ILiS7pp2CUua9A1hiUOcDXD39eFrYW0iZFeK XOW55TnklAh9WM+CDZ33g== X-UI-Out-Filterresults: notjunk:1;V01:K0:/YUW2GCdBR8=:qJaZeNqXhUDdHFFqRYeYEe LS58OFe/n40sXd6o40q+itsfX5ofkr1pBlQYftlBAE9tIup7epvbZjbCij0DmH/4NgZ+yQywO XSWCcXJqRo246hA6QnZWh+AB+2zDVCnfdYGqT6eduogIaBf0ouRrMKjTXipMuXi68jldr61+O VaekEtz+tG5boDAVlexcZWDW5cSfsln1Y0fm0Ex+LsRVx7W2GPz8R76ACILuq4MYr2fxuQeXp XhACq4fa80TlBwt/FKNfNegU1FwJCGckkHmVFoDSTgaZH+nsAL79UDpyIuu1Wnrt/PlJJSIem VT7bdmQY7pAf/msd9MnDPsCeFqdLV2gaEsAOgWYbV/cVnOucWpNF1mMvO60n8Yx4vS01ZiQCW nL1Hhwjnow3tnbrrWMFKhTpBmUuaolHMMxVqcU871S6GKWgeaMDLy+GrMhL8qOvmulE0Gc7ic lqA3V1JIAc3yCtCGrbMlkShJvpRceJXZYS60Pn69SJFrqXQlbVK5W8frIzmfpiBAOo/i8DHHa wumnF5S3C54iZmuRNB7zJ8x7t6/5FQaYfFY2AkUFBZKS2oTRso4dOFKfpD4YxRgwhhnrtwcAS wOJNSlJF83Mje4yBw3ahuJfpUUACYMWwXXB7maB5z4fDb3i0/tkJ55Jw4lJxCw6AB73jzpUf9 TKwiOB9S9Cpo6qEfXfl0fq8Tnlvb29IFds7uh30gG8RyjGkHlu4xXZGGwgzF44jMZUGFZhyVK wrzCOUMp3K3UppnA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 03 February 2016 17:39:46 Sam Ravnborg wrote: > On Wed, Feb 03, 2016 at 02:21:48PM +0100, Arnd Bergmann wrote: > > arch/alpha/include/asm/page.h > > arch/arc/include/asm/page.h > > arch/arm/include/asm/pgtable-3level-types.h > > arch/arm64/include/asm/pgtable-types.h > > arch/ia64/include/asm/page.h > > arch/parisc/include/asm/page.h > > arch/powerpc/include/asm/page.h > > arch/sparc/include/asm/page_32.h > > arch/sparc/include/asm/page_64.h > > For the sparc32 case we use the simpler variants. > According to the comment this is due to limitation in > the way we pass arguments in the sparc32 ABI. > But I have not tried to compare a kernel for sparc32 with > and without the use of structs. > > For sparc64 we use the stricter types (structs). > I did not check other architectures - but just wanted to > tell that the right choice may be architecture dependent. > I see. I was assuming that they all (wrongly) default to the simple definitions. It seems we have these categories: * both defined, but using strict: arch/alpha/include/asm/page.h:#define STRICT_MM_TYPECHECKS arch/sparc/include/asm/page_64.h:#define STRICT_MM_TYPECHECKS arch/ia64/include/asm/page.h:# define STRICT_MM_TYPECHECKS arch/parisc/include/asm/page.h:#define STRICT_MM_TYPECHECKS * both defined, but using non-strict: arch/arc/include/asm/page.h:#undef STRICT_MM_TYPECHECKS arch/arm/include/asm/pgtable-2level-types.h:#undef STRICT_MM_TYPECHECKS arch/arm/include/asm/pgtable-3level-types.h:#undef STRICT_MM_TYPECHECKS arch/arm64/include/asm/pgtable-types.h:#undef STRICT_MM_TYPECHECKS arch/sparc/include/asm/page_32.h:/* #define STRICT_MM_TYPECHECKS */ arch/unicore32/include/asm/page.h:#undef STRICT_MM_TYPECHECKS * Kconfig option: arch/powerpc/Kconfig.debug:config STRICT_MM_TYPECHECKS default n * only strict defined: everything else Arnd