From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752105AbdGRKDD (ORCPT ); Tue, 18 Jul 2017 06:03:03 -0400 Received: from regular1.263xmail.com ([211.150.99.140]:46052 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751538AbdGRKC7 (ORCPT ); Tue, 18 Jul 2017 06:02:59 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: jeffy.chen@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: jeffy.chen@rock-chips.com X-UNIQUE-TAG: <62ce78412e486cc784038d5efef3e220> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 From: Jeffy Chen To: linux-kernel@vger.kernel.org Cc: rui.zhang@intel.com, briannorris@chromium.org, javi.merino@kernel.org, dianders@chromium.org, lukasz.luba@arm.com, Jeffy Chen , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , linux-pm@vger.kernel.org Subject: [PATCH] devfreq: simple_ondemand: Update devfreq stats when governor started Date: Tue, 18 Jul 2017 18:02:51 +0800 Message-Id: <1500372171-7194-1-git-send-email-jeffy.chen@rock-chips.com> X-Mailer: git-send-email 2.1.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If governor suspends soon after started, it may not have the chance to update devfreq stats, which leaves devfreq stats' current frequence be zero. So when the thermal core tries to throttle the power, it would failed to get the correct static power of current frequence and print these warnings: [ 2.024735] core: dev_pm_opp_get_voltage: Invalid parameters [ 2.024743] mali ff9a0000.gpu: Failed to get voltage for frequency 0: -34 ... [ 2.026320] core: dev_pm_opp_get_voltage: Invalid parameters [ 2.026327] mali ff9a0000.gpu: Failed to get voltage for frequency 0: -34 Update devfreq stats when governor started to avoid that. Signed-off-by: Jeffy Chen --- drivers/devfreq/governor_simpleondemand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/devfreq/governor_simpleondemand.c b/drivers/devfreq/governor_simpleondemand.c index ae72ba5..26e0e58 100644 --- a/drivers/devfreq/governor_simpleondemand.c +++ b/drivers/devfreq/governor_simpleondemand.c @@ -98,6 +98,7 @@ static int devfreq_simple_ondemand_handler(struct devfreq *devfreq, { switch (event) { case DEVFREQ_GOV_START: + devfreq_update_stats(devfreq); devfreq_monitor_start(devfreq); break; -- 2.1.4