From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751418AbdGRMcO (ORCPT ); Tue, 18 Jul 2017 08:32:14 -0400 Received: from mx2.suse.de ([195.135.220.15]:35339 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751322AbdGRMcN (ORCPT ); Tue, 18 Jul 2017 08:32:13 -0400 Message-ID: <1500380982.502.12.camel@suse.com> Subject: Re: [RFC PATCH v2] Bluetooth: btusb: Fix memory leak in play_deferred From: Oliver Neukum To: jeffy , Marcel Holtmann Cc: briannorris@chromium.org, dianders@chromium.org, Johan Hedberg , xiyou.wangcong@gmail.com, "Gustavo F. Padovan" , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 18 Jul 2017 14:29:42 +0200 In-Reply-To: <596DDB63.6010206@rock-chips.com> References: <1500343579-9831-1-git-send-email-jeffy.chen@rock-chips.com> <6E21F79E-93AA-4461-BA6B-67715501714F@holtmann.org> <1500363015.16072.5.camel@suse.com> <596DC200.1080006@rock-chips.com> <1500367310.502.0.camel@suse.com> <596DD6AE.2030704@rock-chips.com> <1500370901.502.6.camel@suse.com> <596DDB63.6010206@rock-chips.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 18.07.2017, 17:56 +0800 schrieb jeffy: > Hi Oliver, > > > I think that as soon as one URB fails, you should not even try > > to submit any other deferred URBs. You are taking one out from > > the middle of a sequence. That cannot be right. > ok, that make sense. > > new patch sent :) Where to? Regards Oliver