From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753118AbdGSH6N (ORCPT ); Wed, 19 Jul 2017 03:58:13 -0400 Received: from mxhk.zte.com.cn ([63.217.80.70]:38610 "EHLO mxhk.zte.com.cn" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbdGSH6M (ORCPT ); Wed, 19 Jul 2017 03:58:12 -0400 X-scanvirus: By SEG_CYREN AntiVirus Engine X-scanresult: CLEAN X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 From: Chen Lin To: linux-kernel@vger.kernel.org Cc: zbr@ioremap.net, jiang.biao2@zte.com.cn, chen.lin5@zte.com.cn Subject: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu Date: Wed, 19 Jul 2017 16:08:00 +0800 Message-Id: <1500451680-17885-1-git-send-email-chen.lin5@zte.com.cn> X-Mailer: git-send-email 1.8.3.1 X-MIMETrack: Itemize by SMTP Server on SZSMTP06/server/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-07-19 15:58:00, Serialize by Router on notes_smtp/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2017-07-19 15:57:48, Serialize complete at 2017-07-19 15:57:48 X-MAIL: mse01.zte.com.cn v6J7vukD035952 X-HQIP: 127.0.0.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The byteorder of para rn(W1_READ_ROM id) pass to w1_slave_found must be the same with the byterorder defined in struct w1_reg_num. The rn read from 'rv = w1_read_block(dev, (u8 *)&rn, 8)' is a byte serial and not cpu endian relative, it need to change to cpu endian before passed to w1_slave_found. Signed-off-by: Chen Lin Reviewed-by: Jiang Biao --- Forgot the description in v1. --- drivers/w1/w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 95ea7e6..c531545 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -979,7 +979,7 @@ void w1_search(struct w1_master *dev, u8 search_type, w1_slave_found_callback cb mutex_unlock(&dev->bus_mutex); if (rv == 8 && rn) - cb(dev, rn); + cb(dev, le64_to_cpu(rn)); break; } -- 1.8.3.1