From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754739AbdGSVgr (ORCPT ); Wed, 19 Jul 2017 17:36:47 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36395 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754599AbdGSVgp (ORCPT ); Wed, 19 Jul 2017 17:36:45 -0400 From: Taeung Song To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Milian Wolff , Namhyung Kim Subject: [PATCH v3 0/9] perf annotate: Fix --show-total-period and support --show-nr-samples Date: Thu, 20 Jul 2017 06:36:41 +0900 Message-Id: <1500500201-16506-1-git-send-email-treeze.taeung@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Currently the --show-total-period option of perf-annotate is different from perf-report's. It has two problem like below: (Reported by Namhyung Kim and Milian Wolff) 1) Wrong column i.e. 'Percent' (even though using --show-total-period) 2) Show number of samples, not period So fix this option on both the annotate stdio and TUI browser. And support --show-nr-samples into perf-anntate so that it correpond with perf-report's. The code is available on 'perf/ann-fix-period-v3' branch at git://github.com/taeung/linux-perf.git Thanks, Taeung v3: - Circulate the three view (Percent, Event count, Samples) (Namhyung) - Calculate the percent with period or number of samples (Namhyung) v2: - Separate the first patch into respective paches for easy review (Arnaldo) - Add a patch to introduce 'struct sym_hist_entry' (Arnaldo) - disasm__calc_percent() could receive a pointer to a struct sym_hist_entry instead of two pointer (Arnaldo) - Add a sym_hist_entry into struct disasm_line_samples (Arnaldo) - Fix a case that can't switch 'the total period view' to 'the number of samples view' on the annotate TUI browser (Arnaldo) - Calculate the percentage with 'period', not number of samples Taeung Song (9): perf annotate: Introduce struct sym_hist_entry perf annotate: Properly rename 'sum' to 'total_samples' in struct sym_hist perf annotate: Fix wrong --show-total-period option showing number of samples perf annotate: Show the proper header when using --show-total-period perf anntoate browser: Fix the toggle total period view to show period, not number of samples perf annotate browser: Show the proper header when using --show-total-period perf annotate: Support --show-nr-samples option perf annotate browser: Circulate percent, total period, samples view perf annotate: Use the sample period when calculating the percentage tools/perf/builtin-annotate.c | 6 +- tools/perf/builtin-report.c | 13 ++-- tools/perf/builtin-top.c | 6 +- tools/perf/ui/browsers/annotate.c | 52 +++++++++++---- tools/perf/ui/gtk/annotate.c | 4 +- tools/perf/util/annotate.c | 131 +++++++++++++++++++++++++++----------- tools/perf/util/annotate.h | 15 +++-- 7 files changed, 161 insertions(+), 66 deletions(-) -- 2.7.4