From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: b.zolnierkie@samsung.com, paulus@samba.org,
benh@kernel.crashing.org, adaplas@gmail.com, mbroemme@libmpq.org,
FlorianSchandinat@gmx.de
Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 06/28] video: fbdev: intelfb: constify pci_device_id.
Date: Thu, 20 Jul 2017 23:09:31 +0530 [thread overview]
Message-ID: <1500572393-18844-7-git-send-email-arvind.yadav.cs@gmail.com> (raw)
In-Reply-To: <1500572393-18844-1-git-send-email-arvind.yadav.cs@gmail.com>
pci_device_id are not supposed to change at runtime. All functions
working with pci_device_id provided by <linux/pci.h> work with
const pci_device_id. So mark the non-const structs as const.
File size before:
text data bss dec hex filename
11749 896 24 12669 317d video/fbdev/intelfb/intelfbdrv.o
File size After adding 'const':
text data bss dec hex filename
12173 472 24 12669 317d video/fbdev/intelfb/intelfbdrv.o
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index 6b444400..0127e81 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -173,7 +173,7 @@ static int intelfb_set_fbinfo(struct intelfb_info *dinfo);
#define INTELFB_CLASS_MASK 0
#endif
-static struct pci_device_id intelfb_pci_table[] = {
+static const struct pci_device_id intelfb_pci_table[] = {
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_830M, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA << 8, INTELFB_CLASS_MASK, INTEL_830M },
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_845G, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA << 8, INTELFB_CLASS_MASK, INTEL_845G },
{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_85XGM, PCI_ANY_ID, PCI_ANY_ID, PCI_CLASS_DISPLAY_VGA << 8, INTELFB_CLASS_MASK, INTEL_85XGM },
--
2.7.4
next prev parent reply other threads:[~2017-07-20 17:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170720174007epcas3p2b1560c96711fde38a06d74d24493f952@epcas3p2.samsung.com>
2017-07-20 17:39 ` [PATCH 00/28] constify fbdev pci_device_id Arvind Yadav
2017-07-20 17:39 ` [PATCH 01/28] video: fbdev: radeon: constify pci_device_id Arvind Yadav
2017-07-20 17:39 ` [PATCH 02/28] video: fbdev: atyfb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 03/28] video: fbdev: aty128fb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 04/28] video: fbdev: sunxvr2500: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 05/28] video: fbdev: asiliantfb: " Arvind Yadav
2017-07-20 17:39 ` Arvind Yadav [this message]
2017-07-20 17:39 ` [PATCH 07/28] video: fbdev: pvr2fb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 08/28] video: fbdev: tridentfb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 09/28] video: fbdev: skeletonfb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 10/28] video: fbdev: via: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 11/28] video: fbdev: savage: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 12/28] video: fbdev: riva: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 13/28] video: fbdev: i810: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 14/28] video: fbdev: arkfb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 15/28] video: fbdev: kyro: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 16/28] video: fbdev: vermilion: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 17/28] video: fbdev: nvidia: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 18/28] video: fbdev: mb862xx: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 19/28] video: fbdev: tdfx: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 20/28] video: fbdev: sunxvr500: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 21/28] video: fbdev: imsttfb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 22/28] video: fbdev: pm2fb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 23/28] video: fbdev: gxfb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 24/28] video: fbdev: neofb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 25/28] video: fbdev: s3fb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 26/28] video: fbdev: pm3fb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 27/28] video: fbdev: matroxfb: " Arvind Yadav
2017-07-20 17:39 ` [PATCH 28/28] video: fbdev: vt8623fb: " Arvind Yadav
2017-08-01 15:37 ` [PATCH 00/28] constify fbdev pci_device_id Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500572393-18844-7-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=FlorianSchandinat@gmx.de \
--cc=adaplas@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroemme@libmpq.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®