From: Song liwei <liwei.song@windriver.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>, Len Brown <lenb@kernel.org>
Cc: linux-acpi <linux-acpi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
LiweiSong <liwei.song@windriver.com>
Subject: [PATCH] ACPI, APEI: Fixup incorrect 16-bit access width firmware bug
Date: Fri, 21 Jul 2017 05:41:20 -0400 [thread overview]
Message-ID: <1500630080-18234-1-git-send-email-liwei.song@windriver.com> (raw)
From: Liwei Song <liwei.song@windriver.com>
This is a follow up to commit f712c71f7b2b ("ACPI, APEI: Fixup common
access width firmware bug") fix the following firmware bug:
[Firmware Bug]: APEI: Invalid bit width + offset in GAR [0xb2/16/0/1/1]
This is due to an 8-bit access width is specified for a 16-bit register,
Do bit_width check just like what the original commit have done.
Signed-off-by: Liwei Song <liwei.song@windriver.com>
---
drivers/acpi/apei/apei-base.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
index da370e1..7e47bc6 100644
--- a/drivers/acpi/apei/apei-base.c
+++ b/drivers/acpi/apei/apei-base.c
@@ -610,6 +610,9 @@ static int apei_check_gar(struct acpi_generic_address *reg, u64 *paddr,
else if (bit_width == 64 && bit_offset == 0 && (*paddr & 0x07) == 0 &&
*access_bit_width < 64)
*access_bit_width = 64;
+ else if (bit_width == 16 && bit_offset == 0 && (*paddr & 0x01) == 0 &&
+ *access_bit_width < 16)
+ *access_bit_width = 16;
if ((bit_width + bit_offset) > *access_bit_width) {
pr_warning(FW_BUG APEI_PFX
--
2.7.4
next reply other threads:[~2017-07-21 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 9:41 Song liwei [this message]
2017-07-21 9:56 ` Andy Shevchenko
2017-07-26 6:16 ` Liwei Song
2017-07-26 10:44 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500630080-18234-1-git-send-email-liwei.song@windriver.com \
--to=liwei.song@windriver.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®