From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
Andi Kleen <ak@linux.intel.com>, Paul Bolle <pebolle@tiscali.nl>,
<yingjoe.Chen@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>
Subject: [PATCH] checkpatch: testing more config for Kconfig help text
Date: Fri, 21 Jul 2017 19:03:37 +0800 [thread overview]
Message-ID: <1500635017-1471-1-git-send-email-yingjoe.chen@mediatek.com> (raw)
Current help text check only check a config option if it is followed
by another config.
Adding check for help text if the next entry is menuconfig, choice/
endchoice, comment, menu/endmenu, if/endif, source or end of file.
Change-Id: I9f0b29cebb93df2cadaf77d1027208fd01efd976
Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
---
Hi,
This was sent in Jun 2016[1].
I think we should check every configs for help text.
Please let me know if there's anything need to change.
Thanks
Joe.C
[1] https://lkml.org/lkml/2016/6/24/360
---
scripts/checkpatch.pl | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 2287a0b..f778702 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2778,6 +2778,12 @@ sub process {
next if ($f =~ /^-/);
last if (!$file && $f =~ /^\@\@/);
+ if ($f !~ /^[+\- ]/) {
+ # End of file
+ $is_end = 1;
+ last;
+ }
+
if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate)\s*\"/) {
$is_start = 1;
} elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
@@ -2788,7 +2794,7 @@ sub process {
$f =~ s/#.*//;
$f =~ s/^\s+//;
next if ($f =~ /^$/);
- if ($f =~ /^\s*config\s/) {
+ if ($f =~ /^(?:config\s|menuconfig\s|choice\s|endchoice\s*$|comment\s|menu\s|endmenu\s*$|if\s|endif\s*$|source\s)/) {
$is_end = 1;
last;
}
--
1.7.9.5
reply other threads:[~2017-07-21 11:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500635017-1471-1-git-send-email-yingjoe.chen@mediatek.com \
--to=yingjoe.chen@mediatek.com \
--cc=ak@linux.intel.com \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®