mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Chris Metcalf <cmetcalf@mellanox.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Luiz Capitulino <lcapitulino@redhat.com>,
	Christoph Lameter <cl@linux.com>,
	"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
	Ingo Molnar <mingo@kernel.org>, Mike Galbraith <efault@gmx.de>,
	Rik van Riel <riel@redhat.com>, Wanpeng Li <kernellwp@gmail.com>
Subject: [RFC PATCH 3/9] housekeeping: Provide a dynamic off-case to housekeeping_any_cpu()
Date: Fri, 21 Jul 2017 15:21:24 +0200	[thread overview]
Message-ID: <1500643290-25842-4-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1500643290-25842-1-git-send-email-fweisbec@gmail.com>

housekeeping_any_cpu() doesn't handle correctly the case where
CONFIG_NO_HZ_FULL=y and no CPU is in nohz_full mode. So far no caller
needs this but lets prepare to avoid any future surprise.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Christoph Lameter <cl@linux.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Wanpeng Li <kernellwp@gmail.com>
Cc: Luiz Capitulino <lcapitulino@redhat.com>
---
 include/linux/housekeeping.h | 21 ++++++++-------------
 1 file changed, 8 insertions(+), 13 deletions(-)

diff --git a/include/linux/housekeeping.h b/include/linux/housekeeping.h
index 3d6a8e6..64d0ee5 100644
--- a/include/linux/housekeeping.h
+++ b/include/linux/housekeeping.h
@@ -7,24 +7,19 @@
 
 #ifdef CONFIG_NO_HZ_FULL
 extern cpumask_var_t housekeeping_mask;
-
-static inline int housekeeping_any_cpu(void)
-{
-	return cpumask_any_and(housekeeping_mask, cpu_online_mask);
-}
-
 extern void __init housekeeping_init(void);
-
 #else
-
-static inline int housekeeping_any_cpu(void)
-{
-	return smp_processor_id();
-}
-
 static inline void housekeeping_init(void) { }
 #endif /* CONFIG_NO_HZ_FULL */
 
+static inline int housekeeping_any_cpu(void)
+{
+#ifdef CONFIG_NO_HZ_FULL
+	if (tick_nohz_full_enabled())
+		return cpumask_any_and(housekeeping_mask, cpu_online_mask);
+#endif
+	return smp_processor_id();
+}
 
 static inline const struct cpumask *housekeeping_cpumask(void)
 {
-- 
2.7.4

  parent reply	other threads:[~2017-07-21 13:21 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 13:21 [RFC PATCH 0/9] Introduce housekeeping subsystem Frederic Weisbecker
2017-07-21 13:21 ` [RFC PATCH 1/9] housekeeping: Move housekeeping related code to its own file Frederic Weisbecker
2017-07-21 13:21 ` [RFC PATCH 2/9] watchdog: Use housekeeping_cpumask() instead of ad-hoc version Frederic Weisbecker
2017-07-21 13:21 ` Frederic Weisbecker [this message]
2017-07-21 13:21 ` [RFC PATCH 4/9] housekeeping: Make housekeeping cpumask private Frederic Weisbecker
2017-07-21 13:21 ` [RFC PATCH 5/9] housekeeping: Use its own static key Frederic Weisbecker
2017-07-21 13:21 ` [RFC PATCH 6/9] housekeeping: Rename is_housekeeping_cpu to housekeeping_cpu Frederic Weisbecker
2017-07-21 13:21 ` [RFC PATCH 7/9] housekeeping: Use own boot option, independant from nohz Frederic Weisbecker
2017-08-11 19:09   ` Luiz Capitulino
2017-08-12 14:10     ` Frederic Weisbecker
2017-08-13 15:13       ` Luiz Capitulino
2017-08-14 17:01         ` Frederic Weisbecker
2017-08-14 17:34           ` Luiz Capitulino
2017-08-14 18:29             ` Mike Galbraith
2017-08-15 13:07               ` Frederic Weisbecker
2017-08-15 15:15                 ` Mike Galbraith
2017-08-15 15:30                   ` Paul E. McKenney
2017-08-15 15:52                     ` Christopher Lameter
2017-08-15 15:57                       ` Mike Galbraith
2017-08-15 16:26                         ` Christopher Lameter
2017-08-16 18:00                           ` Mike Galbraith
2017-08-15 15:53                     ` Mike Galbraith
2017-07-21 13:21 ` [RFC PATCH 8/9] housekeeping: Move it under own config, independant from NO_HZ Frederic Weisbecker
2017-07-21 13:21 ` [RFC PATCH 9/9] workqueue: Affine unbound workqueues to housekeeping cpumask Frederic Weisbecker
2017-07-21 19:48 ` [RFC PATCH 0/9] Introduce housekeeping subsystem Chris Metcalf
2017-08-10 12:54   ` Frederic Weisbecker
2017-08-10 13:57     ` Chris Metcalf
2017-08-11  6:36       ` Mike Galbraith
2017-08-11 15:01         ` Frederic Weisbecker
2017-08-11 19:22           ` Luiz Capitulino
2017-08-11 15:08         ` Chris Metcalf
2017-08-11 15:35           ` Christopher Lameter
2017-08-11 15:50             ` Chris Metcalf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500643290-25842-4-git-send-email-fweisbec@gmail.com \
    --to=fweisbec@gmail.com \
    --cc=cl@linux.com \
    --cc=cmetcalf@mellanox.com \
    --cc=efault@gmx.de \
    --cc=kernellwp@gmail.com \
    --cc=lcapitulino@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®