From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753029AbdGXDyP (ORCPT ); Sun, 23 Jul 2017 23:54:15 -0400 Received: from m50-110.126.com ([123.125.50.110]:51483 "EHLO m50-110.126.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbdGXDyA (ORCPT ); Sun, 23 Jul 2017 23:54:00 -0400 From: Meng Dongyang To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Cc: wulf@rock-chips.com, frank.wang@rock-chips.com, Meng Dongyang Subject: [PATCH] usb: dwc2: skip L2 state of hcd if controller work in device mode Date: Mon, 24 Jul 2017 11:56:45 +0800 Message-Id: <1500868605-24144-2-git-send-email-daniel.meng@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1500868605-24144-1-git-send-email-daniel.meng@rock-chips.com> References: <1500868605-24144-1-git-send-email-daniel.meng@rock-chips.com> X-CM-TRANSID: jdKowABX_Kz6bnVZPkQtAw--.24S3 X-Coremail-Antispam: 1Uf129KBjvdXoWrury7trykurW7Aw18WryDZFb_yoWkCrbEgF n5XF4DGr429as5t3W2yw1a9rySqF1qgw1xuFn2vrW5tFs0qr95Xr4jvrZxur98uFW0yF9r AFsFqr1fur1UujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUeE38UUUUUU== X-Originating-IP: [58.22.7.114] X-CM-SenderInfo: h0xd06xkxd01pltxt0a6rslhhfrp/1tbiFgAfj1hgk6+BkAAAsT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the case hcd autosuspend is enabled, the hcd will enter L2 state if no device connected. But if the controller works in otg mode, the gadget driver still works in L0 state if connected with host. This may result in transfer fail when gadget enqueue new request but the hcd driver has set the global state into L2. This patch prevent the hcd enter L2 state if the controller work in device mode. Signed-off-by: Meng Dongyang --- drivers/usb/dwc2/hcd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c index 740c7e8..c263114 100644 --- a/drivers/usb/dwc2/hcd.c +++ b/drivers/usb/dwc2/hcd.c @@ -4388,6 +4388,9 @@ static int _dwc2_hcd_suspend(struct usb_hcd *hcd) spin_lock_irqsave(&hsotg->lock, flags); + if (dwc2_is_device_mode(hsotg)) + goto unlock; + if (hsotg->lx_state != DWC2_L0) goto unlock; @@ -4446,6 +4449,9 @@ static int _dwc2_hcd_resume(struct usb_hcd *hcd) spin_lock_irqsave(&hsotg->lock, flags); + if (dwc2_is_device_mode(hsotg)) + goto unlock; + if (hsotg->lx_state != DWC2_L2) goto unlock; -- 1.9.1