From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751912AbdGXIFy (ORCPT ); Mon, 24 Jul 2017 04:05:54 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:44805 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751328AbdGXIFs (ORCPT ); Mon, 24 Jul 2017 04:05:48 -0400 Message-ID: <1500883545.2391.31.camel@pengutronix.de> Subject: Re: [PATCH] [RESEND] gpu: ipu-v3: add DRM dependency From: Philipp Zabel To: Arnd Bergmann Cc: Daniel Vetter , Stephen Boyd , robdclark@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Mon, 24 Jul 2017 10:05:45 +0200 In-Reply-To: <20170721205625.3375683-1-arnd@arndb.de> References: <20170721205625.3375683-1-arnd@arndb.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On Fri, 2017-07-21 at 22:56 +0200, Arnd Bergmann wrote: > The new PRE/PRG driver code causes a link failure when DRM is disabled: > > drivers/gpu/ipu-v3/ipu-pre.o: In function `ipu_pre_configure': > ipu-pre.c:(.text.ipu_pre_configure+0x18): undefined reference to `drm_format_info' > drivers/gpu/ipu-v3/ipu-prg.o: In function `ipu_prg_format_supported': > ipu-prg.c:(.text.ipu_prg_format_supported+0x8): undefined reference to `drm_format_info' > > Adding a Kconfig dependency on DRM means we don't run into this problem > any more. This might not be the best solution though, as the ipu seems > to have been intentionally kept separate from DRM in the past. > > Fixes: ea9c260514c1 ("gpu: ipu-v3: add driver for Prefetch Resolve Gasket") > Link: https://patchwork.kernel.org/patch/9636665/ > Signed-off-by: Arnd Bergmann > --- > Originally sent on March 21, but got no reply for it. Resending unchanged > as it is still needed in v4.13-rc1 thank you for fix and for the resend. I have the original patch in my inbox, I'm sorry I overlooked it. I would still like to keep the ipu-v3 driver buildable without DRM enabled. For now, I have applied your patch as is. regards Philipp