From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752421AbdGYVF7 (ORCPT ); Tue, 25 Jul 2017 17:05:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46788 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751975AbdGYVF5 (ORCPT ); Tue, 25 Jul 2017 17:05:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 282E9624CC Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=riel@redhat.com Message-ID: <1501016754.26846.22.camel@redhat.com> Subject: Re: [PATCH -mm -v3 1/6] mm, swap: Add swap cache statistics sysfs interface From: Rik van Riel To: "Huang, Ying" , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Minchan Kim , Shaohua Li , Hugh Dickins , Fengguang Wu , Tim Chen , Dave Hansen Date: Tue, 25 Jul 2017 17:05:54 -0400 In-Reply-To: <20170725015151.19502-2-ying.huang@intel.com> References: <20170725015151.19502-1-ying.huang@intel.com> <20170725015151.19502-2-ying.huang@intel.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-INkesESSrJ3PGz9r/mlf" Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 25 Jul 2017 21:05:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-INkesESSrJ3PGz9r/mlf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2017-07-25 at 09:51 +0800, Huang, Ying wrote: > From: Huang Ying >=20 > The swap cache stats could be gotten only via sysrq, which isn't > convenient in some situation.=C2=A0=C2=A0So the sysfs interface of swap c= ache > stats is added for that.=C2=A0=C2=A0The added sysfs directories/files are= as > follow, >=20 > /sys/kernel/mm/swap > /sys/kernel/mm/swap/cache_find_total > /sys/kernel/mm/swap/cache_find_success > /sys/kernel/mm/swap/cache_add > /sys/kernel/mm/swap/cache_del > /sys/kernel/mm/swap/cache_pages >=20 What is the advantage of this vs new fields in /proc/vmstat, which is where most of the VM statistics seem to live? --=20 All rights reversed --=-INkesESSrJ3PGz9r/mlf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJZd7KyAAoJEM553pKExN6DXxUH/2ogC9QtKGIySHKTSlNUWdvc cUIDMVKvQUjW0LcxNuHPJlxhkeLSO7pp3REmlgS7jQaTRh4Y2gEhn4nR5Q0+VKTY Inbmplg1n+avlBkvCkenpeCRGY2amVx19LqKxV/WY7SU6XCY7KhgJWYgduw9B+// y4hQiSf2XUxtr9iYJ/tY/rsoa+xLaO97yrO/qaP6ai36hceecikuCnCOGBfKP/zW t3Mjai1gQ56rK2LMTW1eFIrFo3UmqqFR+VIo1/TvNoCMx9VIg9QfcPJWKZ+CdrMX TidmoF2IKxEA9NjEv9WfYYFmm0qNvKzz/vP6F82CeBvLs3WgGG7xz95vAvzGgBk= =11TG -----END PGP SIGNATURE----- --=-INkesESSrJ3PGz9r/mlf--